You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/12/16 14:57:38 UTC
[GitHub] [ignite] nizhikov opened a new pull request #8580: IGNITE-13865 Support of DateTime as a key or value in .Net and Java
nizhikov opened a new pull request #8580:
URL: https://github.com/apache/ignite/pull/8580
Currently, .Net type `DateTime` can't be used as a key or value in the cache in a way that Java will read values in `java.util.Date`.
This PR fixes it with the new flag `BinaryConfiguration#ForceTimestamp`.
Currently existing `BinaryReflectiveSerializer#_forceTimestamp` becomes obsolete.
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #8580: IGNITE-13865 Support DateTime as a key or value in .NET and Java
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8580:
URL: https://github.com/apache/ignite/pull/8580#discussion_r545194919
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Binary/BinaryReflectiveSerializer.cs
##########
@@ -46,6 +46,7 @@ public sealed class BinaryReflectiveSerializer : IBinarySerializer
private bool _isInUse;
/** Force timestamp flag. */
+ [Obsolete("Deprecated, use BinaryConfiguration.ForceTimestamp instead.")]
Review comment:
Reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #8580: IGNITE-13865 Support DateTime as a key or value in .NET and Java
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #8580:
URL: https://github.com/apache/ignite/pull/8580#discussion_r544913793
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/Marshaller.cs
##########
@@ -950,5 +950,13 @@ private static IBinaryNameMapper GetDefaultNameMapper()
{
return BinaryBasicNameMapper.FullNameInstance;
}
+
+ /// <summary>
+ /// Gets force timestamp flag value.
+ /// </summary>
+ public bool ForceTimestamp()
Review comment:
Let's convert this method to a property
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Binary/BinaryReflectiveSerializer.cs
##########
@@ -46,6 +46,7 @@ public sealed class BinaryReflectiveSerializer : IBinarySerializer
private bool _isInUse;
/** Force timestamp flag. */
+ [Obsolete("Deprecated, use BinaryConfiguration.ForceTimestamp instead.")]
Review comment:
I don't think this deprecation is necessary. This flag is still useful.
PS `[Obsolete]` should be applied to a public property, not a private field
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on pull request #8580: IGNITE-13865 Support DateTime as a key or value in .NET and Java
Posted by GitBox <gi...@apache.org>.
nizhikov commented on pull request #8580:
URL: https://github.com/apache/ignite/pull/8580#issuecomment-747524117
@ptupitsyn I fixed your comments. Please, take a look one more time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #8580: IGNITE-13865 Support DateTime as a key or value in .NET and Java
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #8580:
URL: https://github.com/apache/ignite/pull/8580
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #8580: IGNITE-13865 Support DateTime as a key or value in .NET and Java
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8580:
URL: https://github.com/apache/ignite/pull/8580#discussion_r545195039
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/Marshaller.cs
##########
@@ -950,5 +950,13 @@ private static IBinaryNameMapper GetDefaultNameMapper()
{
return BinaryBasicNameMapper.FullNameInstance;
}
+
+ /// <summary>
+ /// Gets force timestamp flag value.
+ /// </summary>
+ public bool ForceTimestamp()
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org