[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6655: Spark: Handle ResolvingFileIO while determining LocalityPreference

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1093586756


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -164,7 +164,7 @@ private FileIO io(String location) {
     return io;
   }
 
-  private static String implFromLocation(String location) {
+  public static String implFromLocation(String location) {

Review Comment:
   yes that's why I am a bit hesitated, but I think it also makes sense that `ResolvingFileIO` allows the caller to know what is the `FileIO` it will resolve to for each location.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org