You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/08 12:36:40 UTC
[GitHub] [incubator-doris] 924060929 opened a new pull request, #10019: [Enhancement](Nereids) generate pattern by operator
924060929 opened a new pull request, #10019:
URL: https://github.com/apache/incubator-doris/pull/10019
# Proposed changes
generate pattern by operator
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No Need
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#discussion_r893597064
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/JavaLexer.g4:
##########
@@ -0,0 +1,260 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Copied from Antlr and modified for Apache Doris
+
+/*
Review Comment:
We should not modify its origin license.
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/JavaParser.g4:
##########
@@ -0,0 +1,781 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Copied from Antlr and modified for Apache Doris
+
+/*
Review Comment:
Not modify its origin license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#discussion_r893401316
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/operators/OperatorType.java:
##########
@@ -42,6 +42,7 @@ public enum OperatorType {
PHYSICAL_BROADCAST_HASH_JOIN,
// pattern
+ NORMAL_PATTERN,
Review Comment:
what's the different with `PATTERN`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangshuo128 commented on pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
wangshuo128 commented on PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#issuecomment-1150666122
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#discussion_r893502699
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/operators/OperatorType.java:
##########
@@ -42,6 +42,7 @@ public enum OperatorType {
PHYSICAL_BROADCAST_HASH_JOIN,
// pattern
+ NORMAL_PATTERN,
Review Comment:
Pattern must has an `OperatorType`, so add the `NORMAL_PATTERN` for TypePattern and distinguish to ANY / FIXED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#discussion_r893502699
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/operators/OperatorType.java:
##########
@@ -42,6 +42,7 @@ public enum OperatorType {
PHYSICAL_BROADCAST_HASH_JOIN,
// pattern
+ NORMAL_PATTERN,
Review Comment:
Pattern must has an `OperatorType`, so add the `NORMAL_PATTERN` distinct with ANY / FIXED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#discussion_r893502699
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/operators/OperatorType.java:
##########
@@ -42,6 +42,7 @@ public enum OperatorType {
PHYSICAL_BROADCAST_HASH_JOIN,
// pattern
+ NORMAL_PATTERN,
Review Comment:
Pattern must has an `OperatorType`, so add the `NORMAL_PATTERN` for TypePattern and distinguish with ANY / FIXED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#discussion_r894135105
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/JavaLexer.g4:
##########
@@ -0,0 +1,260 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Copied from Antlr and modified for Apache Doris
+
+/*
Review Comment:
done
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/JavaParser.g4:
##########
@@ -0,0 +1,781 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Copied from Antlr and modified for Apache Doris
+
+/*
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10019: [Enhancement](Nereids) generate pattern by operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019#issuecomment-1152164876
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 merged pull request #10019: [Enhancement][Refactor](Nereids) generate pattern by operator and refactor Plan and NODE_TYPE generic type
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged PR #10019:
URL: https://github.com/apache/incubator-doris/pull/10019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org