You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "michaelsembwever (via GitHub)" <gi...@apache.org> on 2023/10/06 13:21:38 UTC
Re: [PR] CASSANDRA-18877 trunk remove byteman from prod sources [cassandra]
michaelsembwever commented on code in PR #2781:
URL: https://github.com/apache/cassandra/pull/2781#discussion_r1348715416
##########
.build/parent-pom-template.xml:
##########
@@ -618,6 +612,8 @@
</exclusion>
</exclusions>
</dependency>
+ <!-- these dependencies have to be of provided scope as they are used by cassandra-dtests and ccm is looking
+ for these libraries in build/lib/jars -->
Review Comment:
👍
##########
.build/parent-pom-template.xml:
##########
@@ -618,6 +612,8 @@
</exclusion>
</exclusions>
</dependency>
+ <!-- these dependencies have to be of provided scope as they are used by cassandra-dtests and ccm is looking
+ for these libraries in build/lib/jars -->
Review Comment:
👍
##########
.build/checkstyle.xml:
##########
@@ -94,7 +94,7 @@
<property name="message" value="Avoid MoreExecutors.directExecutor() in favor of ImmediateExecutor.INSTANCE" />
</module>
<module name="IllegalImport">
- <property name="illegalPkgs" value="junit.framework"/>
+ <property name="illegalPkgs" value="junit.framework,org.jboss.byteman"/>
Review Comment:
👍
##########
.build/checkstyle.xml:
##########
@@ -94,7 +94,7 @@
<property name="message" value="Avoid MoreExecutors.directExecutor() in favor of ImmediateExecutor.INSTANCE" />
</module>
<module name="IllegalImport">
- <property name="illegalPkgs" value="junit.framework"/>
+ <property name="illegalPkgs" value="junit.framework,org.jboss.byteman"/>
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org