You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/28 17:17:26 UTC
[GitHub] [arrow] huitseeker opened a new pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
huitseeker opened a new pull request #9031:
URL: https://github.com/apache/arrow/pull/9031
Cleans some TOML fields and marks some testing crates not-for-publication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-757101028
Hey @huitseeker, the errors in integration tests should be fixed now, may you please kindly rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#discussion_r549454937
##########
File path: rust/parquet_derive_test/Cargo.toml
##########
@@ -18,9 +18,14 @@
[package]
name = "parquet_derive_test"
version = "3.0.0-SNAPSHOT"
+license = "Apache-2.0"
+description = "Apache Parquet implementation in Rust"
Review comment:
Could you update this description as well please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] huitseeker commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
huitseeker commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-756999694
@nevi-me @andygrove The release verification component should now be fixed. Besides that, some integration tests seem to be running on the wrong side of a source incompatible change (e.g. the same compilation errors are met in the unrelated https://github.com/apache/arrow/pull/9137). Those failures should probably be addressed in a distinct PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-751811467
https://issues.apache.org/jira/browse/ARROW-10350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-757101028
Hey @huitseeker, the errors in integration tests should be fixed now, may you please kindly rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#discussion_r549422960
##########
File path: rust/parquet_derive/Cargo.toml
##########
@@ -18,8 +18,13 @@
[package]
name = "parquet_derive"
version = "3.0.0-SNAPSHOT"
+license = "Apache-2.0"
+description = "Apache Parquet implementation in Rust"
Review comment:
I think we should have a more accurate description of what the parquet_derive crate provides rather than use the same description as the main parquet crate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paddyhoran closed pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
paddyhoran closed pull request #9031:
URL: https://github.com/apache/arrow/pull/9031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-755112031
I'll complete this during the week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-751894354
@huitseeker Unfortunately the release verification scripts will need updating to reflect the changes to these Cargo.toml files. If you look at the CI failure you should be able to reproduce this locally by running the same script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] huitseeker commented on pull request #9031: ARROW-10350: [Rust] Fixes to publication metadata in Cargo.toml
Posted by GitBox <gi...@apache.org>.
huitseeker commented on pull request #9031:
URL: https://github.com/apache/arrow/pull/9031#issuecomment-756999694
@nevi-me @andygrove The release verification component should now be fixed. Besides that, some integration tests seem to be running on the wrong side of a source incompatible change (e.g. the same compilation errors are met in the unrelated https://github.com/apache/arrow/pull/9137). Those failures should probably be addressed in a distinct PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org