You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2015/07/03 08:10:04 UTC

[jira] [Commented] (HADOOP-12176) smart-apply-patch.sh fails to identify git patch prefixes in some cases

    [ https://issues.apache.org/jira/browse/HADOOP-12176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612879#comment-14612879 ] 

Allen Wittenauer commented on HADOOP-12176:
-------------------------------------------

I've opted to toss smart-apply-patch because the whole reason it needs to do that work is, frankly, stupid when one can just re-run git for nearly the same cost. See my rewrite at HADOOP-12156 as part of Yetus.

> smart-apply-patch.sh fails to identify git patch prefixes in some cases
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-12176
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12176
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HADOOP-12176-01.patch
>
>
> after HADOOP-12018, git apply supported with --no-prefix.
> But for some patches this detection will identify git patch with prefix as no-prefix patch and fails to apply.
> Example case is ; If patch contains a line changed with '+++' or '---' somewhere in between. May be a javadoc update. This makes detection wrong and git apply will fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)