You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/27 04:28:26 UTC
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18922
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
[thirdparty] update googletest up to 1.12.1 version
Along with other fixes and updates, googletest v1.12.1 includes the fix
that allows for building the library with CLANG 13 and newer [1].
[1] https://github.com/google/googletest/issues/3427
Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
---
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gmock-remove-unused-gunit-iwyu-pragma.patch
M thirdparty/vars.sh
4 files changed, 11 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18922/1
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 3: Verified+1
unrelated test failure in TsTabletManagerITest.TestTableStats (ASAN)
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 14:31:44 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 1: Code-Review+1
Tested on M1 MacBook Pro, with Xcode 13.3: thirdparty and Kudu build ran successful. Kudu starts fine, and tests are running as expected.
Since there were no issues, I think after this patch, we are up to date in terms of Xcode support. (helpful for https://gerrit.cloudera.org/#/c/18822/ )
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 10:04:55 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Yingchun Lai, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18922
to look at the new patch set (#3).
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
[thirdparty] update googletest up to 1.12.1 version
Along with other fixes and updates, googletest v1.12.1 includes the fix
that allows for building the library with CLANG 13 and newer [1].
[1] https://github.com/google/googletest/issues/3427
Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
---
A build-support/iwyu/mappings/gmock.imp
M build-support/iwyu/mappings/gtest.imp
M src/kudu/client/client-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/logging-test.cc
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gmock-remove-unused-gunit-iwyu-pragma.patch
A thirdparty/patches/gmock-update-iwyu-pragma.patch
M thirdparty/vars.sh
11 files changed, 344 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18922/3
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18922/3/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
http://gerrit.cloudera.org:8080/#/c/18922/3/thirdparty/download-thirdparty.sh@181
PS3, Line 181: GMOCK_PATCHLEVEL=2
does this need to be patch level 2 if we have a new GMOCK_VERSION?
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 06:45:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 1: Code-Review+1
We have to mute the errors reported by IWYU by mistake.
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 27 Aug 2022 07:37:39 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 4: Verified+1
unrelated test failure
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 16:39:21 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
[thirdparty] update googletest up to 1.12.1 version
Along with other fixes and updates, googletest v1.12.1 includes the fix
that allows for building the library with CLANG 13 and newer [1].
[1] https://github.com/google/googletest/issues/3427
Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Reviewed-on: http://gerrit.cloudera.org:8080/18922
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
A build-support/iwyu/mappings/gmock.imp
M build-support/iwyu/mappings/gtest.imp
M src/kudu/client/client-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/logging-test.cc
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gmock-remove-unused-gunit-iwyu-pragma.patch
A thirdparty/patches/gmock-update-iwyu-pragma.patch
M thirdparty/vars.sh
11 files changed, 343 insertions(+), 22 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Yingchun Lai, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18922
to look at the new patch set (#2).
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
[thirdparty] update googletest up to 1.12.1 version
Along with other fixes and updates, googletest v1.12.1 includes the fix
that allows for building the library with CLANG 13 and newer [1].
[1] https://github.com/google/googletest/issues/3427
Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
---
M build-support/iwyu/mappings/gtest.imp
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gmock-remove-unused-gunit-iwyu-pragma.patch
A thirdparty/patches/gmock-update-iwyu-pragma.patch
M thirdparty/vars.sh
6 files changed, 182 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18922/2
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 06:44:41 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 15:39:59 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Yingchun Lai, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18922
to look at the new patch set (#4).
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
[thirdparty] update googletest up to 1.12.1 version
Along with other fixes and updates, googletest v1.12.1 includes the fix
that allows for building the library with CLANG 13 and newer [1].
[1] https://github.com/google/googletest/issues/3427
Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
---
A build-support/iwyu/mappings/gmock.imp
M build-support/iwyu/mappings/gtest.imp
M src/kudu/client/client-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/logging-test.cc
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gmock-remove-unused-gunit-iwyu-pragma.patch
A thirdparty/patches/gmock-update-iwyu-pragma.patch
M thirdparty/vars.sh
11 files changed, 343 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/18922/4
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18922/3/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
http://gerrit.cloudera.org:8080/#/c/18922/3/thirdparty/download-thirdparty.sh@181
PS3, Line 181: GMOCK_PATCHLEVEL=2
> does this need to be patch level 2 if we have a new GMOCK_VERSION?
Good point -- it's enough to start from scratch since the patch level files are in the directory where the sources are unpacked, and that's versioned. I updated the patchlevel.
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 15:28:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 4: Verified+1
unrelated test failure: AuthzProviders/TSAuthzTxnOpsITest.CommitForNonauthorizedUsers/Ranger
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 16:39:06 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Removed Verified+1 by Alexey Serbin <al...@apache.org>
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18922 )
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Patch Set 2: Verified+1
unrelated test failure: rebalancer_tool-test.2
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 03:03:03 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] update googletest up to 1.12.1 version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] update googletest up to 1.12.1 version
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic1a398cbb93a6edb918e84e05927feb4b067058c
Gerrit-Change-Number: 18922
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>