You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/26 07:15:10 UTC
[GitHub] [spark] MaxGekk opened a new pull request #32347: [SPARK-35224][SQL][TESTS][3.1] Fix buffer overflow in `MutableProjectionSuite`
MaxGekk opened a new pull request #32347:
URL: https://github.com/apache/spark/pull/32347
### What changes were proposed in this pull request?
In the test `"unsafe buffer with NO_CODEGEN"` of `MutableProjectionSuite`, fix unsafe buffer size calculation to be able to place all input fields without buffer overflow + meta-data.
### Why are the changes needed?
To make the test suite `MutableProjectionSuite` more stable.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the affected test suite:
```
$ build/sbt "test:testOnly *MutableProjectionSuite"
```
Authored-by: Max Gekk <ma...@gmail.com>
Signed-off-by: Max Gekk <ma...@gmail.com>
(cherry picked from commit d572a859891547f73b57ae8c9a3b800c48029678)
Signed-off-by: Max Gekk <ma...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826622615
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42460/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826682418
GA passed. Merging to 3.1 and 3.0 (I ran tests for 3.0 locally).
Thank you @maropu and @cloud-fan for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #32347:
URL: https://github.com/apache/spark/pull/32347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826580593
**[Test build #137938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137938/testReport)** for PR 32347 at commit [`1349c4f`](https://github.com/apache/spark/commit/1349c4f717e84ebc2da99b4b2384dcb476e81e28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826622615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826580593
**[Test build #137938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137938/testReport)** for PR 32347 at commit [`1349c4f`](https://github.com/apache/spark/commit/1349c4f717e84ebc2da99b4b2384dcb476e81e28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826793019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137938/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826788616
**[Test build #137938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137938/testReport)** for PR 32347 at commit [`1349c4f`](https://github.com/apache/spark/commit/1349c4f717e84ebc2da99b4b2384dcb476e81e28).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32347: [SPARK-35224][SQL][TESTS][3.1][3.0] Fix buffer overflow in `MutableProjectionSuite`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32347:
URL: https://github.com/apache/spark/pull/32347#issuecomment-826622558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org