[jira] [Commented] (ROCKETMQ-75) RemotingCommand header decoding swallows exceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837143#comment-15837143 ] 

ASF GitHub Bot commented on ROCKETMQ-75:
----------------------------------------

GitHub user shroman opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/51

    [ROCKETMQ-75] RemotingCommand header decoding swallows exceptions

    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-75
    
    Added logging on errors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-75

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit e0144072d4ee6dbfae8beb45aee1f0abbc6e147e
Author: shtykh_roman <rs...@yahoo.com>
Date:   2017-01-25T03:57:51Z

    [ROCKETMQ-75] RemotingCommand header decoding swallows exceptions
    
    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-75
    
    Added logging on errors.

----


> RemotingCommand header decoding swallows exceptions
> ---------------------------------------------------
>
>                 Key: ROCKETMQ-75
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-75
>             Project: Apache RocketMQ
>          Issue Type: Bug
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> {{RemotingCommand}} header decoding swallows exceptions, which is ok if you want to skip unparseable fields, but then logging is needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)