You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/12 02:27:53 UTC
[GitHub] [flink] diohabara opened a new pull request #13123: [hotfix][docs]Correct the grammar
diohabara opened a new pull request #13123:
URL: https://github.com/apache/flink/pull/13123
## What is the purpose of the change
To fix typo in the documentation.
## Brief change log
Correct Scala code in the documentation since it was written like Java.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with @Public(Evolving): no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, - - ZooKeeper: no
- The S3 file system connector: no
None of the above.
## Documentation
Does this pull request introduce a new feature?: no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #13123: [hotfix][docs]Correct the grammar
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #13123:
URL: https://github.com/apache/flink/pull/13123#issuecomment-739964272
Already fixed in 8983bb0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13123: [hotfix][docs]Correct the grammar
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13123:
URL: https://github.com/apache/flink/pull/13123#issuecomment-672516148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f09131c5dc3b1a55ffaebaf9a8f4db6bc48ee931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f09131c5dc3b1a55ffaebaf9a8f4db6bc48ee931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f09131c5dc3b1a55ffaebaf9a8f4db6bc48ee931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol closed pull request #13123: [hotfix][docs]Correct the grammar
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #13123:
URL: https://github.com/apache/flink/pull/13123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13123: [hotfix][docs]Correct the grammar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13123:
URL: https://github.com/apache/flink/pull/13123#issuecomment-672516148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f09131c5dc3b1a55ffaebaf9a8f4db6bc48ee931",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5425",
"triggerID" : "f09131c5dc3b1a55ffaebaf9a8f4db6bc48ee931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f09131c5dc3b1a55ffaebaf9a8f4db6bc48ee931 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5425)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13123: [hotfix][docs]Correct the grammar
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13123:
URL: https://github.com/apache/flink/pull/13123#issuecomment-672478874
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f09131c5dc3b1a55ffaebaf9a8f4db6bc48ee931 (Wed Aug 12 02:30:27 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org