You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/23 16:29:44 UTC
[GitHub] [apisix-website] slorber opened a new pull request #318: chore: Test Docusaurus webpack 5 support
slorber opened a new pull request #318:
URL: https://github.com/apache/apisix-website/pull/318
Use an unreleased version of Docusaurus to test the webpack5 support works for this site.
See also https://github.com/facebook/docusaurus/pull/4089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] slorber commented on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
slorber commented on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-826072544
Thanks ๐ happy to see i18n used there๐
And thanks for the sponsorship
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* processing.
Building with commit c92f21cf088ed3f08c159f636dbf15ff22b9d0ef
https://app.netlify.com/sites/apisix/deploys/608d83a32c04ea000856d38b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* processing.
Building with commit 7d4831bb3377845b99ce04608c30b2adfb00be7a
https://app.netlify.com/sites/apisix/deploys/608d929742af350008d095d2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* processing.
Building with commit a56d7ae7e868e373d8c7a9168cb2a01d39c152da
https://app.netlify.com/sites/apisix/deploys/608bd46900ade700087c5f77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* ready!
Built with commit 53aae2443b42eb0ffe297222e67d99d967c57e93
https://deploy-preview-318--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-826007856
Wow! Welcome & Thanks for your PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* ready!
Built with commit 7d4831bb3377845b99ce04608c30b2adfb00be7a
https://deploy-preview-318--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* processing.
Building with commit 53aae2443b42eb0ffe297222e67d99d967c57e93
https://app.netlify.com/sites/apisix/deploys/6082f5f2949049000899caa3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] slorber commented on a change in pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
slorber commented on a change in pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#discussion_r624542274
##########
File path: website/src/theme/DocSidebar/index.js
##########
@@ -162,19 +175,14 @@ function DocSidebar({
isHidden,
docPluginId
}) {
+ const showAnnouncementBar = useShowAnnouncementBar();
const [showResponsiveSidebar, setShowResponsiveSidebar] = useState(false);
const {
navbar: {
hideOnScroll
},
hideableSidebar
} = useThemeConfig();
- const {
- isAnnouncementBarClosed
- } = useUserPreferencesContext();
- const {
- scrollY
- } = useScrollPosition();
Review comment:
breaking change on the useScrollPosition internal hook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* processing.
Building with commit 0734854ee501d7205557024f15811551364931c5
https://app.netlify.com/sites/apisix/deploys/608c3b4ce5910b0007e1f2fd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #318:
URL: https://github.com/apache/apisix-website/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] slorber commented on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
slorber commented on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-830668701
ready to review, let me know if anything does not work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138
Deploy preview for *apisix* ready!
Built with commit a56d7ae7e868e373d8c7a9168cb2a01d39c152da
https://deploy-preview-318--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] slorber commented on pull request #318: chore: Test Docusaurus webpack 5 support
Posted by GitBox <gi...@apache.org>.
slorber commented on pull request #318:
URL: https://github.com/apache/apisix-website/pull/318#issuecomment-826072544
Thanks ๐ happy to see i18n used there๐
And thanks for the sponsorship
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org