You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by do...@apache.org on 2001/12/01 04:31:40 UTC
cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
donaldp 01/11/30 19:31:40
Modified: src/main/org/apache/tools/ant Project.java
Log:
Remove unsetProperty() because it allows tasks to break immutability.
Revision Changes Path
1.82 +0 -15 jakarta-ant/src/main/org/apache/tools/ant/Project.java
Index: Project.java
===================================================================
RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -r1.81 -r1.82
--- Project.java 2001/11/30 17:35:06 1.81
+++ Project.java 2001/12/01 03:31:40 1.82
@@ -342,21 +342,6 @@
}
/**
- * unset a named property, unless it is a user property.
- * <i>the immutability policy is not implemented at this level</i>
- * @param name name of property
- */
- public void unsetProperty(String name) {
- // command line properties take precedence
- if (null != userProperties.get(name)) {
- log("Won\'t unset user property " + name, MSG_VERBOSE);
- return;
- }
- log("Unsetting project property: " + name, MSG_DEBUG);
- properties.remove(name);
- }
-
- /**
* set a user property, which can not be overwritten by
* set/unset property calls
* @see #setProperty(String,String)
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
Posted by Magesh Umasankar <um...@apache.org>.
As this is a Post 1.4.1 method addition, I guess nobody cared
that it would be backwards incompatible?
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Monday, December 03, 2001 7:51 PM
Subject: RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
Project.java
> Doesn't this break backward compatability? I don't think we can just
remove
> public methods.
>
> Conor
>
>
> > -----Original Message-----
> > From: donaldp@apache.org [mailto:donaldp@apache.org]
> > Sent: Saturday, 1 December 2001 2:32 PM
> > To: jakarta-ant-cvs@apache.org
> > Subject: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
> > Project.java
> >
> >
> > donaldp 01/11/30 19:31:40
> >
> > Modified: src/main/org/apache/tools/ant Project.java
> > Log:
> > Remove unsetProperty() because it allows tasks to break immutability.
> >
> > Revision Changes Path
> > 1.82 +0 -15
> > jakarta-ant/src/main/org/apache/tools/ant/Project.java
> >
> > Index: Project.java
> > ===================================================================
> > RCS file:
> > /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v
> > retrieving revision 1.81
> > retrieving revision 1.82
> > diff -u -r1.81 -r1.82
> > --- Project.java 2001/11/30 17:35:06 1.81
> > +++ Project.java 2001/12/01 03:31:40 1.82
> > @@ -342,21 +342,6 @@
> > }
> >
> > /**
> > - * unset a named property, unless it is a user property.
> > - * <i>the immutability policy is not implemented at this
level</i>
> > - * @param name name of property
> > - */
> > - public void unsetProperty(String name) {
> > - // command line properties take precedence
> > - if (null != userProperties.get(name)) {
> > - log("Won\'t unset user property " + name, MSG_VERBOSE);
> > - return;
> > - }
> > - log("Unsetting project property: " + name, MSG_DEBUG);
> > - properties.remove(name);
> > - }
> > -
> > - /**
> > * set a user property, which can not be overwritten by
> > * set/unset property calls
> > * @see #setProperty(String,String)
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
> >
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
Posted by Jose Alberto Fernandez <j_...@yahoo.com>.
This code was never released. It was only included in the current CVS version.
Jose Alberto
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Tuesday, December 04, 2001 12:51 AM
Subject: RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
> Doesn't this break backward compatability? I don't think we can just remove
> public methods.
>
> Conor
>
>
> > -----Original Message-----
> > From: donaldp@apache.org [mailto:donaldp@apache.org]
> > Sent: Saturday, 1 December 2001 2:32 PM
> > To: jakarta-ant-cvs@apache.org
> > Subject: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
> > Project.java
> >
> >
> > donaldp 01/11/30 19:31:40
> >
> > Modified: src/main/org/apache/tools/ant Project.java
> > Log:
> > Remove unsetProperty() because it allows tasks to break immutability.
> >
> > Revision Changes Path
> > 1.82 +0 -15
> > jakarta-ant/src/main/org/apache/tools/ant/Project.java
> >
> > Index: Project.java
> > ===================================================================
> > RCS file:
> > /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v
> > retrieving revision 1.81
> > retrieving revision 1.82
> > diff -u -r1.81 -r1.82
> > --- Project.java 2001/11/30 17:35:06 1.81
> > +++ Project.java 2001/12/01 03:31:40 1.82
> > @@ -342,21 +342,6 @@
> > }
> >
> > /**
> > - * unset a named property, unless it is a user property.
> > - * <i>the immutability policy is not implemented at this level</i>
> > - * @param name name of property
> > - */
> > - public void unsetProperty(String name) {
> > - // command line properties take precedence
> > - if (null != userProperties.get(name)) {
> > - log("Won\'t unset user property " + name, MSG_VERBOSE);
> > - return;
> > - }
> > - log("Unsetting project property: " + name, MSG_DEBUG);
> > - properties.remove(name);
> > - }
> > -
> > - /**
> > * set a user property, which can not be overwritten by
> > * set/unset property calls
> > * @see #setProperty(String,String)
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> > For additional commands, e-mail: <ma...@jakarta.apache.org>
> >
> >
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
OK,
Cool. I have just been catching up on the patches applied :-).
Conor
> -----Original Message-----
> From: Erik Hatcher [mailto:jakarta-ant@ehatchersolutions.com]
> Sent: Tuesday, 4 December 2001 12:05 PM
> To: Ant Developers List
> Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
> Project.java
>
>
> We discussed this.... it was only added by Stefan and used in one of his
> test cases... he refactored it so that this method could be removed.
>
> Erik
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
We discussed this.... it was only added by Stefan and used in one of his
test cases... he refactored it so that this method could be removed.
Erik
----- Original Message -----
From: "Conor MacNeill" <co...@cortexebusiness.com.au>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Monday, December 03, 2001 7:51 PM
Subject: RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
Project.java
> Doesn't this break backward compatability? I don't think we can just
remove
> public methods.
>
> Conor
>
>
> > -----Original Message-----
> > From: donaldp@apache.org [mailto:donaldp@apache.org]
> > Sent: Saturday, 1 December 2001 2:32 PM
> > To: jakarta-ant-cvs@apache.org
> > Subject: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
> > Project.java
> >
> >
> > donaldp 01/11/30 19:31:40
> >
> > Modified: src/main/org/apache/tools/ant Project.java
> > Log:
> > Remove unsetProperty() because it allows tasks to break immutability.
> >
> > Revision Changes Path
> > 1.82 +0 -15
> > jakarta-ant/src/main/org/apache/tools/ant/Project.java
> >
> > Index: Project.java
> > ===================================================================
> > RCS file:
> > /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v
> > retrieving revision 1.81
> > retrieving revision 1.82
> > diff -u -r1.81 -r1.82
> > --- Project.java 2001/11/30 17:35:06 1.81
> > +++ Project.java 2001/12/01 03:31:40 1.82
> > @@ -342,21 +342,6 @@
> > }
> >
> > /**
> > - * unset a named property, unless it is a user property.
> > - * <i>the immutability policy is not implemented at this
level</i>
> > - * @param name name of property
> > - */
> > - public void unsetProperty(String name) {
> > - // command line properties take precedence
> > - if (null != userProperties.get(name)) {
> > - log("Won\'t unset user property " + name, MSG_VERBOSE);
> > - return;
> > - }
> > - log("Unsetting project property: " + name, MSG_DEBUG);
> > - properties.remove(name);
> > - }
> > -
> > - /**
> > * set a user property, which can not be overwritten by
> > * set/unset property calls
> > * @see #setProperty(String,String)
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
> >
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
Posted by Peter Donald <pe...@apache.org>.
On Tue, 4 Dec 2001 11:51, Conor MacNeill wrote:
> Doesn't this break backward compatability?
nope. It was added post last release and only to support a test case that no
longer needs it. Read the threads regarding immutability.
--
Cheers,
Pete
---------------------------------------------------
"It is easy to dodge our responsibilities, but we
cannot dodge the consequences of dodging our
responsibilities." -Josiah Stamp
---------------------------------------------------
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Doesn't this break backward compatability? I don't think we can just remove
public methods.
Conor
> -----Original Message-----
> From: donaldp@apache.org [mailto:donaldp@apache.org]
> Sent: Saturday, 1 December 2001 2:32 PM
> To: jakarta-ant-cvs@apache.org
> Subject: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
> Project.java
>
>
> donaldp 01/11/30 19:31:40
>
> Modified: src/main/org/apache/tools/ant Project.java
> Log:
> Remove unsetProperty() because it allows tasks to break immutability.
>
> Revision Changes Path
> 1.82 +0 -15
> jakarta-ant/src/main/org/apache/tools/ant/Project.java
>
> Index: Project.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v
> retrieving revision 1.81
> retrieving revision 1.82
> diff -u -r1.81 -r1.82
> --- Project.java 2001/11/30 17:35:06 1.81
> +++ Project.java 2001/12/01 03:31:40 1.82
> @@ -342,21 +342,6 @@
> }
>
> /**
> - * unset a named property, unless it is a user property.
> - * <i>the immutability policy is not implemented at this level</i>
> - * @param name name of property
> - */
> - public void unsetProperty(String name) {
> - // command line properties take precedence
> - if (null != userProperties.get(name)) {
> - log("Won\'t unset user property " + name, MSG_VERBOSE);
> - return;
> - }
> - log("Unsetting project property: " + name, MSG_DEBUG);
> - properties.remove(name);
> - }
> -
> - /**
> * set a user property, which can not be overwritten by
> * set/unset property calls
> * @see #setProperty(String,String)
>
>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>