[GitHub] beam pull request #2463: [BEAM-1799] Move HashingFn to io/common, switch to ...

[ssisk <gi...@git.apache.org>]

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2463

    [BEAM-1799] Move HashingFn to io/common, switch to better hash

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    HadoopInputFormatIO has a hashing function that can be used to easily verify reads - this moves it to a common place so other IOs can use it. 
    
    It also switches from SHA1 -> murmur since that's a good, fast hash (which is all we need). That meant I had to update the hashes in the unit tests.
    
    cc @dhalperi please take a look
    cc @diptikul this will change some of the code you're working on, wanted to make sure you're aware. Should be an easy merge, but wanted to give you a heads up. Also, I had thought that the Guava 19 dependency in HIFIO was a hard requirement, but I seem to be able to mvn verify & run the HIFIO ITs without it. Is there something I should be doing to cause the problem? (perhaps it was in the removed cassandra-unit dependency?)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam common-hash

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2463
    
----
commit 11de90abec49cb13da0147a27fc1cfcdd969a786
Author: Stephen Sisk <si...@google.com>
Date:   2017-04-07T19:59:28Z

    Move HashingFn to io/common, switch to better hash

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2463: [BEAM-1799] Move HashingFn to io/common, switch to ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2463


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---