[GitHub] [lucene] mocobeta commented on a change in pull request #739: Adapt release smoke tester for 9.1

[GitBox <gi...@apache.org>]

mocobeta commented on a change in pull request #739:
URL: https://github.com/apache/lucene/pull/739#discussion_r824603725



##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -574,10 +574,11 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision, version, testArgs):
   #       raise RuntimeError('lucene: file "%s" is missing from artifact %s' % (fileName, artifact))
   #     in_root_folder.remove(fileName)
 
-  expected_folders = ['analysis', 'backward-codecs', 'benchmark', 'classification', 'codecs', 'core',
-                      'demo', 'expressions', 'facet', 'grouping', 'highlighter', 'join',
-                      'luke', 'memory', 'misc', 'monitor', 'queries', 'queryparser', 'replicator',
-                      'sandbox', 'spatial-extras', 'spatial3d', 'suggest', 'test-framework', 'licenses']
+  expected_folders = ['analysis', 'analysis.tests', 'backward-codecs', 'benchmark', 'classification', 'codecs',

Review comment:
       The variable `expected_folders` is used to validate src distribution, not the binary distribution - I think "*.tests" folders should appear here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org