You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Adam Lally (JIRA)" <ui...@incubator.apache.org> on 2006/11/17 15:35:39 UTC

[jira] Created: (UIMA-45) Review and clean up unit tests

Review and clean up unit tests
------------------------------

                 Key: UIMA-45
                 URL: http://issues.apache.org/jira/browse/UIMA-45
             Project: UIMA
          Issue Type: Task
          Components: Build, Packaging and Test
            Reporter: Adam Lally
            Priority: Minor


Things to review and clean up:
1) The way that the tests find resource files is hacked up right now.  For legacy reasons they use classes in the junit_extension package to locate files.  The location of the files is decided by TestPropertyReader.getJUnitBasePath().  Since Maven requires (or at least strongly encourages) loading resources through the classpath, I hacked up getJUnitBasePath() to do a ClassLoader lookup on a dummy resource and return the directory in which it is found.  This ought to be cleaned up at some point.

2) grep for TODO in src/test/java in both uimaj-core and uimaj-cpe.  There are many things that need to be addressed.  Several unit tests were commented out entirely because they didn't work right in Maven for some reason.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (UIMA-45) Review and clean up unit tests

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463614 ] 

Michael Baessler commented on UIMA-45:
--------------------------------------

I'm not done with all of that... I did #1 and some on #2 but did not complete... Hopefully I get this done this week since I will be on vacation next week.

> Review and clean up unit tests
> ------------------------------
>
>                 Key: UIMA-45
>                 URL: https://issues.apache.org/jira/browse/UIMA-45
>             Project: UIMA
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Adam Lally
>         Assigned To: Michael Baessler
>            Priority: Minor
>             Fix For: 2.1
>
>
> Things to review and clean up:
> 1) The way that the tests find resource files is hacked up right now.  For legacy reasons they use classes in the junit_extension package to locate files.  The location of the files is decided by TestPropertyReader.getJUnitBasePath().  Since Maven requires (or at least strongly encourages) loading resources through the classpath, I hacked up getJUnitBasePath() to do a ClassLoader lookup on a dummy resource and return the directory in which it is found.  This ought to be cleaned up at some point.
> 2) grep for TODO in src/test/java in both uimaj-core and uimaj-cpe.  There are many things that need to be addressed.  Several unit tests were commented out entirely because they didn't work right in Maven for some reason.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (UIMA-45) Review and clean up unit tests

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/UIMA-45?page=all ]

Michael Baessler reassigned UIMA-45:
------------------------------------

    Assignee: Michael Baessler

> Review and clean up unit tests
> ------------------------------
>
>                 Key: UIMA-45
>                 URL: http://issues.apache.org/jira/browse/UIMA-45
>             Project: UIMA
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Adam Lally
>         Assigned To: Michael Baessler
>            Priority: Minor
>
> Things to review and clean up:
> 1) The way that the tests find resource files is hacked up right now.  For legacy reasons they use classes in the junit_extension package to locate files.  The location of the files is decided by TestPropertyReader.getJUnitBasePath().  Since Maven requires (or at least strongly encourages) loading resources through the classpath, I hacked up getJUnitBasePath() to do a ClassLoader lookup on a dummy resource and return the directory in which it is found.  This ought to be cleaned up at some point.
> 2) grep for TODO in src/test/java in both uimaj-core and uimaj-cpe.  There are many things that need to be addressed.  Several unit tests were commented out entirely because they didn't work right in Maven for some reason.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (UIMA-45) Review and clean up unit tests

Posted by "Adam Lally (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Lally updated UIMA-45:
---------------------------

    Fix Version/s: 2.1

Is this done?  I'm pretty sure Michael did part #1 and made it at least some progress on #2.  



> Review and clean up unit tests
> ------------------------------
>
>                 Key: UIMA-45
>                 URL: https://issues.apache.org/jira/browse/UIMA-45
>             Project: UIMA
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Adam Lally
>         Assigned To: Michael Baessler
>            Priority: Minor
>             Fix For: 2.1
>
>
> Things to review and clean up:
> 1) The way that the tests find resource files is hacked up right now.  For legacy reasons they use classes in the junit_extension package to locate files.  The location of the files is decided by TestPropertyReader.getJUnitBasePath().  Since Maven requires (or at least strongly encourages) loading resources through the classpath, I hacked up getJUnitBasePath() to do a ClassLoader lookup on a dummy resource and return the directory in which it is found.  This ought to be cleaned up at some point.
> 2) grep for TODO in src/test/java in both uimaj-core and uimaj-cpe.  There are many things that need to be addressed.  Several unit tests were commented out entirely because they didn't work right in Maven for some reason.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Work started: (UIMA-45) Review and clean up unit tests

Posted by "Adam Lally (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on UIMA-45 started by Adam Lally.

> Review and clean up unit tests
> ------------------------------
>
>                 Key: UIMA-45
>                 URL: https://issues.apache.org/jira/browse/UIMA-45
>             Project: UIMA
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Adam Lally
>         Assigned To: Adam Lally
>            Priority: Minor
>             Fix For: 2.1
>
>
> Things to review and clean up:
> 1) The way that the tests find resource files is hacked up right now.  For legacy reasons they use classes in the junit_extension package to locate files.  The location of the files is decided by TestPropertyReader.getJUnitBasePath().  Since Maven requires (or at least strongly encourages) loading resources through the classpath, I hacked up getJUnitBasePath() to do a ClassLoader lookup on a dummy resource and return the directory in which it is found.  This ought to be cleaned up at some point.
> 2) grep for TODO in src/test/java in both uimaj-core and uimaj-cpe.  There are many things that need to be addressed.  Several unit tests were commented out entirely because they didn't work right in Maven for some reason.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (UIMA-45) Review and clean up unit tests

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Baessler reassigned UIMA-45:
------------------------------------

    Assignee: Adam Lally  (was: Michael Baessler)

I have done all where I was able to do something. 

Please take a look at the others and check if we have to do something before 2.1 release

> Review and clean up unit tests
> ------------------------------
>
>                 Key: UIMA-45
>                 URL: https://issues.apache.org/jira/browse/UIMA-45
>             Project: UIMA
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Adam Lally
>         Assigned To: Adam Lally
>            Priority: Minor
>             Fix For: 2.1
>
>
> Things to review and clean up:
> 1) The way that the tests find resource files is hacked up right now.  For legacy reasons they use classes in the junit_extension package to locate files.  The location of the files is decided by TestPropertyReader.getJUnitBasePath().  Since Maven requires (or at least strongly encourages) loading resources through the classpath, I hacked up getJUnitBasePath() to do a ClassLoader lookup on a dummy resource and return the directory in which it is found.  This ought to be cleaned up at some point.
> 2) grep for TODO in src/test/java in both uimaj-core and uimaj-cpe.  There are many things that need to be addressed.  Several unit tests were commented out entirely because they didn't work right in Maven for some reason.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (UIMA-45) Review and clean up unit tests

Posted by "Adam Lally (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Lally closed UIMA-45.
--------------------------

    Resolution: Fixed

Significant cleanup has been done.  Further items can be opened under separate JIRA issues.

> Review and clean up unit tests
> ------------------------------
>
>                 Key: UIMA-45
>                 URL: https://issues.apache.org/jira/browse/UIMA-45
>             Project: UIMA
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Adam Lally
>         Assigned To: Adam Lally
>            Priority: Minor
>             Fix For: 2.1
>
>
> Things to review and clean up:
> 1) The way that the tests find resource files is hacked up right now.  For legacy reasons they use classes in the junit_extension package to locate files.  The location of the files is decided by TestPropertyReader.getJUnitBasePath().  Since Maven requires (or at least strongly encourages) loading resources through the classpath, I hacked up getJUnitBasePath() to do a ClassLoader lookup on a dummy resource and return the directory in which it is found.  This ought to be cleaned up at some point.
> 2) grep for TODO in src/test/java in both uimaj-core and uimaj-cpe.  There are many things that need to be addressed.  Several unit tests were commented out entirely because they didn't work right in Maven for some reason.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira