[GitHub] [incubator-pinot] kishoreg commented on issue #3723: Remove auto-gen class files that were checked-in

[GitBox <gi...@apache.org>]

kishoreg commented on issue #3723: Remove auto-gen class files that were checked-in
URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-495746485
 
 
   There are a couple of things we need to consider here
   
   1. we will have to modify Travis script to install thrift before triggering the build (this is not hard, we can use thrift docker images)
   2. Adds the additional step of installing thrift in order to build Pinot locally. Currently, since the generated code is checked. This is a one-time thing
   
   The only way to avoid the above steps is to migrate to Avro or Protobuf but that will be a bigger change.
   
   If there are no concerns, we can add the steps to install thrift to Travis script.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org