You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/04/02 22:31:23 UTC
[Impala-ASF-CR] Fixing type in SimpleLogger::Flush()
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9893
Change subject: Fixing type in SimpleLogger::Flush()
......................................................................
Fixing type in SimpleLogger::Flush()
Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
---
M be/src/util/simple-logger.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9893/1
--
To view, visit http://gerrit.cloudera.org:8080/9893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
Gerrit-Change-Number: 9893
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] Fixing typo in SimpleLogger::Flush()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9893 )
Change subject: Fixing typo in SimpleLogger::Flush()
......................................................................
Fixing typo in SimpleLogger::Flush()
Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
Reviewed-on: http://gerrit.cloudera.org:8080/9893
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/simple-logger.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bharath Vissapragada: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
Gerrit-Change-Number: 9893
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Fixing typo in SimpleLogger::Flush()
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9893 )
Change subject: Fixing typo in SimpleLogger::Flush()
......................................................................
Fixing typo in SimpleLogger::Flush()
Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
---
M be/src/util/simple-logger.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9893/2
--
To view, visit http://gerrit.cloudera.org:8080/9893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
Gerrit-Change-Number: 9893
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Fixing typo in SimpleLogger::Flush()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9893 )
Change subject: Fixing typo in SimpleLogger::Flush()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
Gerrit-Change-Number: 9893
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 21:39:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fixing typo in SimpleLogger::Flush()
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9893 )
Change subject: Fixing typo in SimpleLogger::Flush()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
Gerrit-Change-Number: 9893
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Mon, 02 Apr 2018 22:32:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fixing typo in SimpleLogger::Flush()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9893 )
Change subject: Fixing typo in SimpleLogger::Flush()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2254/
--
To view, visit http://gerrit.cloudera.org:8080/9893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce0525e8db133f4b1df653b995e3eb108619050
Gerrit-Change-Number: 9893
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 17:34:36 +0000
Gerrit-HasComments: No