You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:11:45 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #7206: [C++] Fix pattern consumer's deadlock for topics auto discovery

BewareMyPower opened a new pull request #7206:
URL: https://github.com/apache/pulsar/pull/7206


   Fixes #7168 
   
   ### Motivation
   
   When a pattern consumer is blocked by `receive()`, the `mutex_` will be held until new messages arrived. If the auto discovery timer task found new topics and tried to subscribe them, `mutex_` must be acquired first, then the deadlock happened.
   
   ### Modifications
   
   - Release the `mutex_` after the consumer's state was verified.
   - Change unit tests to verify that new topics could be subscribed when the consumer's blocked by `receive(Message&)` or `receive(Message&, int)` methods.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests, such as *BasicEndToEndTest.testPatternMultiTopicsConsumerAutoDiscovery*.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #7206: [C++] Fix pattern consumer's deadlock for topics auto discovery

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7206:
URL: https://github.com/apache/pulsar/pull/7206#issuecomment-640956200


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #7206: [C++] Fix pattern consumer's deadlock for topics auto discovery

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7206:
URL: https://github.com/apache/pulsar/pull/7206#issuecomment-640745197


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #7206: [Issue 7168][C++] Fix pattern consumer's deadlock for topics auto discovery

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7206:
URL: https://github.com/apache/pulsar/pull/7206


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org