You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/05 13:00:50 UTC

[GitHub] [httpcomponents-client] arturobernalg opened a new pull request #281: Minor Improvement:

arturobernalg opened a new pull request #281:
URL: https://github.com/apache/httpcomponents-client/pull/281


   * Avoid duplicate code
   * Simplify if else
   * Inline variables
   * Add log Catch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] [httpcomponents-client] ok2c commented on pull request #281: Minor Improvement:

Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #281:
URL: https://github.com/apache/httpcomponents-client/pull/281#issuecomment-774206224


   @arturobernalg I would even use DEBUG priority. Could you please take `Add log Catch` out of this patch and put it into a separate PR for now? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] [httpcomponents-client] arturobernalg commented on pull request #281: Minor Improvement:

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #281:
URL: https://github.com/apache/httpcomponents-client/pull/281#issuecomment-774208957


   > @arturobernalg I would even use DEBUG priority. Could you please take `Add log Catch` out of this patch and put it into a separate PR for now?
   
   HI @ok2c 
   
   agree. We can talk about the LOG.XX by mail or later. removed from PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] [httpcomponents-client] arturobernalg edited a comment on pull request #281: Minor Improvement:

Posted by GitBox <gi...@apache.org>.
arturobernalg edited a comment on pull request #281:
URL: https://github.com/apache/httpcomponents-client/pull/281#issuecomment-774208957


   > @arturobernalg I would even use DEBUG priority. Could you please take `Add log Catch` out of this patch and put it into a separate PR for now?
   
   HI @ok2c 
   
   agree. We can talk about the LOG.XX by later. I remove from this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] [httpcomponents-client] ok2c merged pull request #281: Minor Improvement:

Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #281:
URL: https://github.com/apache/httpcomponents-client/pull/281


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] [httpcomponents-client] arturobernalg commented on pull request #281: Minor Improvement:

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #281:
URL: https://github.com/apache/httpcomponents-client/pull/281#issuecomment-774184446


   > @arturobernalg If you really want to log those exceptions should they be logged at the ERROR priority?
   
   Hi @ok2c 
   
   IMO We should inform in somewhere that's an error occurs. What about a warning?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] [httpcomponents-client] ok2c commented on pull request #281: Minor Improvement:

Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #281:
URL: https://github.com/apache/httpcomponents-client/pull/281#issuecomment-774172294


   @arturobernalg If you really want to log those exceptions should they be logged at the ERROR priority?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org