[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2358: [ST-Engine][seatunnel-seatunnel-starter] seatunnel-seatunnel-starter

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #2358:
URL: https://github.com/apache/incubator-seatunnel/pull/2358#discussion_r937343924


##########
seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/Constant.java:
##########
@@ -22,5 +22,17 @@ public class Constant {
 
     public static final String SEATUNNEL_ID_GENERATOR_NAME = "SeaTunnelIdGenerator";
 
-    public static final String DEFAULT_SEATUNNEL_CLUSTER_NAME = "SeaTunnel";
+    public static final String DEFAULT_SEATUNNEL_CLUSTER_NAME = "seatunnel";
+
+    /**
+     * The default port number for the cluster auto-discovery mechanism's
+     * multicast communication.
+     */
+    public static final int DEFAULT_SEATUNNEL_MULTICAST_PORT = 53326;

Review Comment:
   > Is this parameter configurable? Often users may use a specific port.
   
   Yes, the port can be overwrite by this code
   
   ```
       public SeaTunnelConfig build(SeaTunnelConfig config) {
           try {
               parseAndBuildConfig(config);
           } catch (Exception e) {
               throw ExceptionUtil.rethrow(e);
           }
           config.setHazelcastConfig(ConfigProvider.locateAndGetMemberConfig(getProperties()));
           return config;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org