You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/08/11 18:52:28 UTC
[kudu-CR](branch-1.18.x) KUDU-2439 properly update Messenger instance counter
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23283
Change subject: KUDU-2439 properly update Messenger instance counter
......................................................................
KUDU-2439 properly update Messenger instance counter
This is a follow-up to d1413014255df62a6e38550552a8596644aa0033.
Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Reviewed-on: http://gerrit.cloudera.org:8080/23277
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 8e873eb37b157a0cf7cb97cc7690367de9707107)
---
M src/kudu/rpc/messenger.cc
M src/kudu/util/before_and_after_main.h
2 files changed, 16 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23283/1
--
To view, visit http://gerrit.cloudera.org:8080/23283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Gerrit-Change-Number: 23283
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.18.x) KUDU-2439 properly update Messenger instance counter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2439 properly update Messenger instance counter
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Gerrit-Change-Number: 23283
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.18.x) KUDU-2439 properly update Messenger instance counter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23283 )
Change subject: KUDU-2439 properly update Messenger instance counter
......................................................................
Patch Set 1: Verified+1
unrelated failures of known flaky tests (TSAN): KUDU-3598, KUDU-3660, KUDU-3687
--
To view, visit http://gerrit.cloudera.org:8080/23283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Gerrit-Change-Number: 23283
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Aug 2025 21:19:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-2439 properly update Messenger instance counter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23283 )
Change subject: KUDU-2439 properly update Messenger instance counter
......................................................................
KUDU-2439 properly update Messenger instance counter
This is a follow-up to d1413014255df62a6e38550552a8596644aa0033.
Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Reviewed-on: http://gerrit.cloudera.org:8080/23277
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 8e873eb37b157a0cf7cb97cc7690367de9707107)
Reviewed-on: http://gerrit.cloudera.org:8080/23283
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/rpc/messenger.cc
M src/kudu/util/before_and_after_main.h
2 files changed, 16 insertions(+), 4 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Gerrit-Change-Number: 23283
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.18.x) KUDU-2439 properly update Messenger instance counter
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23283 )
Change subject: KUDU-2439 properly update Messenger instance counter
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1680/
--
To view, visit http://gerrit.cloudera.org:8080/23283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Gerrit-Change-Number: 23283
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Aug 2025 18:52:36 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-2439 properly update Messenger instance counter
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23283 )
Change subject: KUDU-2439 properly update Messenger instance counter
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Gerrit-Change-Number: 23283
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Aug 2025 19:21:31 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) KUDU-2439 properly update Messenger instance counter
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23283 )
Change subject: KUDU-2439 properly update Messenger instance counter
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1680/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b96e7157e1efd930092cc9e5bfde33bf523098
Gerrit-Change-Number: 23283
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Aug 2025 20:41:18 +0000
Gerrit-HasComments: No