You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/03/09 15:06:22 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5532: minor: fix clippy problem in new version.
jackwener opened a new pull request, #5532:
URL: https://github.com/apache/arrow-datafusion/pull/5532
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
N/A
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5532: minor: fix clippy problem in new version.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5532:
URL: https://github.com/apache/arrow-datafusion/pull/5532#discussion_r1131196008
##########
datafusion/core/src/physical_plan/aggregates/no_grouping.rs:
##########
@@ -164,7 +164,7 @@ impl RecordBatchStream for AggregateStream {
/// Perform group-by aggregation for the given [`RecordBatch`].
///
-/// If successfull, this returns the additional number of bytes that were allocated during this process.
+/// If successfully, this returns the additional number of bytes that were allocated during this process.
Review Comment:
```suggestion
/// If successful, this returns the additional number of bytes that were allocated during this process.
```
(very minor, in case you have to update the PR again )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5532: minor: fix clippy problem in new version.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5532:
URL: https://github.com/apache/arrow-datafusion/pull/5532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5532: minor: fix clippy problem in new version.
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #5532:
URL: https://github.com/apache/arrow-datafusion/pull/5532#discussion_r1131200513
##########
datafusion/core/src/physical_plan/aggregates/no_grouping.rs:
##########
@@ -164,7 +164,7 @@ impl RecordBatchStream for AggregateStream {
/// Perform group-by aggregation for the given [`RecordBatch`].
///
-/// If successfull, this returns the additional number of bytes that were allocated during this process.
+/// If successfully, this returns the additional number of bytes that were allocated during this process.
Review Comment:
I also find a same new typo, look like I should update again 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5532: minor: fix clippy problem in new version.
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5532:
URL: https://github.com/apache/arrow-datafusion/pull/5532#issuecomment-1462424938
Benchmark runs are scheduled for baseline = 8a1cb7e3cae36361c576a735c5e23ab746e0b9ea and contender = 9878ee011b99a57a6c3f87c0205061307d1e8498. 9878ee011b99a57a6c3f87c0205061307d1e8498 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ffd23f5848984b8cba236def75d77cfe...8d7e774307b242a8ae502527f4aa3eee/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7c1292707fb945129cc93e0f472f8a9f...018a4cc0c24e458da10b2296f18b4222/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/41022f88108c45919c6dc657001e3cda...be8fc14b9c53423ab0c0a0101992b750/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/928bff0f20544d53a70b8ffa1f30d2ef...0307c075103a40d49404f205c698c3f0/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5532: minor: fix clippy problem in new version.
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #5532:
URL: https://github.com/apache/arrow-datafusion/pull/5532#discussion_r1131200513
##########
datafusion/core/src/physical_plan/aggregates/no_grouping.rs:
##########
@@ -164,7 +164,7 @@ impl RecordBatchStream for AggregateStream {
/// Perform group-by aggregation for the given [`RecordBatch`].
///
-/// If successfull, this returns the additional number of bytes that were allocated during this process.
+/// If successfully, this returns the additional number of bytes that were allocated during this process.
Review Comment:
I also find a same new typo, look like I should update again 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org