[GitHub] [pinot] KKcorps commented on a diff in pull request #10447: Do not record operator stats when tracing is enabled

["KKcorps (via GitHub)" <gi...@apache.org>]

KKcorps commented on code in PR #10447:
URL: https://github.com/apache/pinot/pull/10447#discussion_r1156864303


##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ExecutionStatsAggregator.java:
##########
@@ -363,19 +362,20 @@ public void setStats(@Nullable String rawTableName, BrokerResponseNative brokerR
 
   public void setStageLevelStats(@Nullable String rawTableName, BrokerResponseStats brokerResponseStats,
       @Nullable BrokerMetrics brokerMetrics) {
-    setStats(rawTableName, brokerResponseStats, brokerMetrics);
-
-    brokerResponseStats.setNumBlocks(_numBlocks);
-    brokerResponseStats.setNumRows(_numRows);
-    brokerResponseStats.setStageExecutionTimeMs(_stageExecutionTimeMs);
-    brokerResponseStats.setStageExecWallTimeMs(_stageExecEndTimeMs - _stageExecStartTimeMs);
-    brokerResponseStats.setStageExecutionUnit(_stageExecutionUnit);

Review Comment:
   This is when tracing is disabled right? You mentioned that we only want wall time in that case. The rest should be filled only when tracing is enabled.
   
   OperationExecution time is not correct name right? This is aggregated stage time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org