[jira] [Commented] (GEODE-8921) Enable "extra qualifications" warning on Windows builds

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279146#comment-17279146 ] 

ASF GitHub Bot commented on GEODE-8921:
---------------------------------------

pdxcodemonkey opened a new pull request #741:
URL: https://github.com/apache/geode-native/pull/741


   - This would bite developers from time to time, because code with extra
     qualifications will build on Windows, but all other platforms will
     flag it with a warning and break the build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enable "extra qualifications" warning on Windows builds
> -------------------------------------------------------
>
>                 Key: GEODE-8921
>                 URL: https://issues.apache.org/jira/browse/GEODE-8921
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Blake Bender
>            Assignee: Blake Bender
>            Priority: Major
>
> As a developer, I would like to be assured as much as possible that, if my code builds on the platform I'm running on my dev machine, it will build for all of our supported platforms.  One very notable exception to this has been the "extra qualifications" warning, which is not enabled by default in Visual Studio.  Thus, the following code will build in our environment on Windows, but _only_ on Windows:
> {code:java}
> class Foo
> { 
> public: 
>   void Foo::bar(); 
> };  {code}
> This is warning C4596 in the Microsoft tools, and we need to explicitly enable it in our builds.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)