You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "korlov42 (via GitHub)" <gi...@apache.org> on 2024/01/22 09:00:02 UTC
[PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
korlov42 opened a new pull request, #3070:
URL: https://github.com/apache/ignite-3/pull/3070
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #3070:
URL: https://github.com/apache/ignite-3/pull/3070#discussion_r1463115429
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/NestedLoopJoinNode.java:
##########
@@ -462,7 +463,9 @@ private RightJoin(
@Override
protected void rewindInternal() {
left = null;
- rightNotMatchedIndexes.clear();
+ if (rightNotMatchedIndexes != null) {
Review Comment:
I don't see any related changes, which can lead to the change sequentially. Which test show the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #3070:
URL: https://github.com/apache/ignite-3/pull/3070#discussion_r1463311924
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/NestedLoopJoinNode.java:
##########
@@ -462,7 +463,9 @@ private RightJoin(
@Override
protected void rewindInternal() {
left = null;
- rightNotMatchedIndexes.clear();
+ if (rightNotMatchedIndexes != null) {
Review Comment:
one of the test from SqlLogic suite. I've got NPE here and decided, that the problem was in missed check. Turns out the issue was a bit trickier... I changed execution test in order to cover this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #3070:
URL: https://github.com/apache/ignite-3/pull/3070#discussion_r1463108255
##########
modules/sql-engine/src/integrationTest/sql/sqlite/join/join1.test:
##########
@@ -22,12 +22,6 @@ INSERT INTO t2 VALUES(2,3,4);
statement ok
INSERT INTO t2 VALUES(3,4,5);
-query III rowsort
Review Comment:
let's better to use single test disable instead of moving to separate file
`skipif ignite3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #3070:
URL: https://github.com/apache/ignite-3/pull/3070#discussion_r1463140189
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItIndexSpoolTest.java:
##########
@@ -29,13 +29,15 @@
import org.apache.ignite.internal.sql.BaseSqlIntegrationTest;
import org.apache.ignite.table.Table;
import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
/**
* Index spool test.
*/
+@Disabled("https://issues.apache.org/jira/browse/IGNITE-21286")
Review Comment:
there is separate jira for this https://issues.apache.org/jira/browse/IGNITE-21050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #3070:
URL: https://github.com/apache/ignite-3/pull/3070#discussion_r1463308635
##########
modules/sql-engine/src/integrationTest/sql/sqlite/join/join1.test:
##########
@@ -22,12 +22,6 @@ INSERT INTO t2 VALUES(2,3,4);
statement ok
INSERT INTO t2 VALUES(3,4,5);
-query III rowsort
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #3070:
URL: https://github.com/apache/ignite-3/pull/3070#discussion_r1463105278
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItIndexSpoolTest.java:
##########
@@ -29,13 +29,15 @@
import org.apache.ignite.internal.sql.BaseSqlIntegrationTest;
import org.apache.ignite.table.Table;
import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
/**
* Index spool test.
*/
+@Disabled("https://issues.apache.org/jira/browse/IGNITE-21286")
Review Comment:
may be consider to remove it at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20880 Sql. Fix hanging TPC-H queries [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 merged PR #3070:
URL: https://github.com/apache/ignite-3/pull/3070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org