Re: [PR] feat(rose): migrate rose chart to v1 chart data API [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #41726:
URL: https://github.com/apache/superset/pull/41726#discussion_r3517858793


##########
superset-frontend/plugins/legacy-plugin-chart-rose/src/transformProps.ts:
##########
@@ -27,12 +33,28 @@ export default function transformProps(chartProps: ChartProps) {
     richTooltip,
     roseAreaProportion,
     sliceId,
+    metrics,
+    timeCompare,
+    comparisonType,
   } = formData;
 
+  // v1 responses arrive as flattened pivot records; the legacy
+  // explore_json endpoint delivered the timestamp-keyed shape directly.
+  const rawData = queriesData[0].data;
+  const data = Array.isArray(rawData)
+    ? transformData(rawData, {
+        metricLabels: ensureIsArray(metrics as QueryFormMetric[]).map(
+          getMetricLabel,
+        ),
+        timeCompare: ensureIsArray(timeCompare),
+        comparisonType,

Review Comment:
   Good catch... 'absolute' is now normalized to 'difference' in both buildQuery and the column mapping, with a test pinning the compare_type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org