You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/30 21:20:44 UTC
[GitHub] [arrow] gcca opened a new pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
gcca opened a new pull request #10846:
URL: https://github.com/apache/arrow/pull/10846
Add the super-scalar variant to set a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nirandaperera commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
nirandaperera commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-890546943
@cyb70289 this was discussed in this PR #10679. The idea came from @wesm.
Ref: https://graphics.stanford.edu/~seander/bithacks.html#ConditionalSetOrClearBitsWithoutBranching
The idea is to check if these two methods have any performance implications.
```c++
void SetBitTo(uint8_t* bits, int64_t i, bool bit_is_set) {
bits[i / 8] ^= static_cast<uint8_t>(-static_cast<uint8_t>(bit_is_set) ^ bits[i / 8]) & kBitmask[i % 8];
}
void SetBitSuperscalarTo(uint8_t* bits, int64_t i, bool bit_is_set) {
bits[i / 8] = (bits[i / 8] & ~kBitmask[i % 8]) | (-static_cast<uint8_t>(bit_is_set) & kBitmask[i % 8]);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-890159961
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891038090
@github-actions crossbow submit conda-cpp-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891038598
Benchmark runs are scheduled for baseline = 1c5e5a4ed77eb4622f868718ad0eceaa40b378fb and contender = 6467c37db2db1cdd18704f4cef374c54b5f0e1bc. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/14627a46f3874cd6bdff06007e99b669...74bcfecc34d6446fb9a0baddfdd6925a/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/81884a4d150849b58293068abad9aebc...22838819a26245d6b8005185611373a9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/487a091c22fe46a3aa20e0fa4bc3d98f...d9652b553265403d8b023e726de3150d/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nirandaperera commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
nirandaperera commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-890543942
@gcca the title should be "ARROW-13473: [C++] Add super-scalar impl for BitUtil::SetBitTo"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nirandaperera commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
nirandaperera commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891242899
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891038280
Revision: 6467c37db2db1cdd18704f4cef374c54b5f0e1bc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-688](https://github.com/ursacomputing/crossbow/branches/all?query=actions-688)
|Task|Status|
|----|------|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-688-github-test-conda-cpp-valgrind)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-688-azure-test-r-linux-valgrind)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891037555
@github-actions crossbow submit *valgrind*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891037923
@ursabot please benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-890291119
Do you have benchmark results showing this code is faster than original one?
Compilers are pretty smart in optimizing these common code patterns. Without solid benchmark data, I would prefer simpler code.
Disassembler shows the dumb `if else` actually generates almost same code as this bithack trick. Modern CPUs all have `conditional move` instructions to remove trivial branches.
https://godbolt.org/z/fqzs7rGev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou removed a comment on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou removed a comment on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891038090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891038598
Benchmark runs are scheduled for baseline = 1c5e5a4ed77eb4622f868718ad0eceaa40b378fb and contender = 6467c37db2db1cdd18704f4cef374c54b5f0e1bc. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/14627a46f3874cd6bdff06007e99b669...74bcfecc34d6446fb9a0baddfdd6925a/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/81884a4d150849b58293068abad9aebc...22838819a26245d6b8005185611373a9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/487a091c22fe46a3aa20e0fa4bc3d98f...d9652b553265403d8b023e726de3150d/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891243095
Benchmark runs are scheduled for baseline = 29c8c4d643fd99178dc426f60428c0c08cebf58a and contender = e159bdc7f2735ee53e49470a867dfd7c36d6a8e1. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/762da0fc68bb4ff8b0754849dcbf0846...26055ba06fab493095bb5f847706b91e/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/86a485cef4f34a459dd6d7b7773a9ec7...e25cb5dae8394b3594358e7f1eb1930c/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d1a50c962641460db496fe5af6512029...9a2c029f241b42d28327aa1c16f4c857/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-893093479
Benchmark result and static analysis both show this patch is not necessary for modern compiler and hardware (I do believe bithack tricks are very useful and interesting to inspire practical algorithms).
Can we close this pr and related jira card? @gcca @nirandaperera
And welcome more contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891038598
Benchmark runs are scheduled for baseline = 1c5e5a4ed77eb4622f868718ad0eceaa40b378fb and contender = 6467c37db2db1cdd18704f4cef374c54b5f0e1bc. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/14627a46f3874cd6bdff06007e99b669...74bcfecc34d6446fb9a0baddfdd6925a/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/81884a4d150849b58293068abad9aebc...22838819a26245d6b8005185611373a9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/487a091c22fe46a3aa20e0fa4bc3d98f...d9652b553265403d8b023e726de3150d/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-895371919
Agreed with @cyb70289 that this doesn't seem to show promise. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891243095
Benchmark runs are scheduled for baseline = 29c8c4d643fd99178dc426f60428c0c08cebf58a and contender = e159bdc7f2735ee53e49470a867dfd7c36d6a8e1. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/762da0fc68bb4ff8b0754849dcbf0846...26055ba06fab493095bb5f847706b91e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/86a485cef4f34a459dd6d7b7773a9ec7...e25cb5dae8394b3594358e7f1eb1930c/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d1a50c962641460db496fe5af6512029...9a2c029f241b42d28327aa1c16f4c857/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891038598
Benchmark runs are scheduled for baseline = 1c5e5a4ed77eb4622f868718ad0eceaa40b378fb and contender = 6467c37db2db1cdd18704f4cef374c54b5f0e1bc. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/14627a46f3874cd6bdff06007e99b669...74bcfecc34d6446fb9a0baddfdd6925a/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/81884a4d150849b58293068abad9aebc...22838819a26245d6b8005185611373a9/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/487a091c22fe46a3aa20e0fa4bc3d98f...d9652b553265403d8b023e726de3150d/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891243095
Benchmark runs are scheduled for baseline = 29c8c4d643fd99178dc426f60428c0c08cebf58a and contender = e159bdc7f2735ee53e49470a867dfd7c36d6a8e1. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/762da0fc68bb4ff8b0754849dcbf0846...26055ba06fab493095bb5f847706b91e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/86a485cef4f34a459dd6d7b7773a9ec7...e25cb5dae8394b3594358e7f1eb1930c/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d1a50c962641460db496fe5af6512029...9a2c029f241b42d28327aa1c16f4c857/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-893093479
Benchmark result and static analysis both show this patch is not necessary for modern compiler and hardware (I do believe bithack tricks are very useful and interesting to inspire practical algorithms).
Can we close this pr and related jira card? @gcca @nirandaperera
And welcome more contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #10846:
URL: https://github.com/apache/arrow/pull/10846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891742240
This doesn't seem very conclusive. Recommend closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#discussion_r680982433
##########
File path: cpp/src/arrow/util/bit_util.h
##########
@@ -310,8 +310,13 @@ static inline void SetBitTo(uint8_t* bits, int64_t i, bool bit_is_set) {
// "Conditionally set or clear bits without branching"
// NOTE: this seems to confuse Valgrind as it reads from potentially
// uninitialized memory
+#ifdef SUPERSCALAR_CPU
Review comment:
Where does this come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] gcca commented on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
gcca commented on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891081791
@nirandaperera: these are the results when running the benchmarks
**Current version**
|Benchmark | Time | CPU | Iterations |UserCounters |
|------------------------|---------------------------------------|----------|--------------|----------|
|BenchmarkBitmapVisitBitsetAnd/32768/0 | 57776803 ns | 57772660 ns | 11 | bytes_per_second=553.895k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/0 | 232098279 ns | 232094670 ns | 3 | bytes_per_second=551.499k/s|
|BenchmarkBitmapVisitBitsetAnd/32768/0 | 57848824 ns | 57843817 ns | 12| bytes_per_second=553.214k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/0 | 234126020 ns | 234115416 ns | 3 |bytes_per_second=546.739k/s|
|BenchmarkBitmapVisitBitsetAnd/32768/1 | 61148854 ns | 61148534 ns | 10| bytes_per_second=523.316k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/1 | 244266155 ns | 244259941 ns | 3 |bytes_per_second=524.032k/s|
|BenchmarkBitmapVisitBitsetAnd/32768/2 | 61629097 ns | 61623725 ns | 11 |bytes_per_second=519.281k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/2 | 247708290 ns | 247696540 ns | 3| bytes_per_second=516.761k/s|
**Superscalar CPU version**
|Benchmark | Time | CPU | Iterations |UserCounters|
|----------------------------|---------------------------------|------------|--------------|----------|
|BenchmarkBitmapVisitBitsetAnd/32768/0 |58131617 ns | 58130347 ns | 12 |bytes_per_second=550.487k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/0 |233650397 ns | 233636376 ns | 3| bytes_per_second=547.86k/s|
|BenchmarkBitmapVisitBitsetAnd/32768/0 |58134623 ns | 58133313 ns | 12 |bytes_per_second=550.459k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/0 |232643208 ns | 232640618 ns | 3| bytes_per_second=550.205k/s|
|BenchmarkBitmapVisitBitsetAnd/32768/1 | 61623058 ns | 61614097 ns | 11| bytes_per_second=519.362k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/1 |251259627 ns | 251242745 ns | 3 |bytes_per_second=509.467k/s|
|BenchmarkBitmapVisitBitsetAnd/32768/2 |62266910 ns | 62259970 ns | 12| bytes_per_second=513.974k/s|
|BenchmarkBitmapVisitBitsetAnd/131072/2 | 246426455 ns | 246412586 ns | 3| bytes_per_second=519.454k/s|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #10846: ARROW 13473: [C++] Add super-scalar impl for BitUtil::SetBitTo
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #10846:
URL: https://github.com/apache/arrow/pull/10846#issuecomment-891243095
Benchmark runs are scheduled for baseline = 29c8c4d643fd99178dc426f60428c0c08cebf58a and contender = e159bdc7f2735ee53e49470a867dfd7c36d6a8e1. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/762da0fc68bb4ff8b0754849dcbf0846...26055ba06fab493095bb5f847706b91e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/86a485cef4f34a459dd6d7b7773a9ec7...e25cb5dae8394b3594358e7f1eb1930c/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d1a50c962641460db496fe5af6512029...9a2c029f241b42d28327aa1c16f4c857/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org