[jira] [Comment Edited] (GEODE-2473) redis-cli hangs if Geode unable to process command properly

["Galen O'Sullivan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897895#comment-15897895 ] 

Galen O'Sullivan edited comment on GEODE-2473 at 3/6/17 8:42 PM:
-----------------------------------------------------------------

The Redis hash, set commands create regions with the name of the hash/set. We have constraints on region names which mean that regions with names that aren't roughly alphanumeric will throw errors. However, the errors are caught by GFSH (which the Redis adapter uses to create regions), and then the GFSH adapter returns OK. We loop forever in the {{do/while}} loop in {{RegionProvider.createRegionGlobally(String key)}}.

Result shouldn't be OK in this case.


was (Author: gosullivan):
The Redis hash, set commands create regions with the name of the hash/set. We have constraints on region names which mean that regions with names that aren't roughly alphanumeric will throw errors.

> redis-cli hangs if Geode unable to process command properly
> -----------------------------------------------------------
>
>                 Key: GEODE-2473
>                 URL: https://issues.apache.org/jira/browse/GEODE-2473
>             Project: Geode
>          Issue Type: Sub-task
>          Components: redis
>            Reporter: Hitesh Khamesra
>
> Here is the command  "HSET companies:1000 name "John Smith""
> "GeodeRedisServer-WorkerThread-1" #86 prio=5 os_prio=0 tid=0x00007f1a20002800 nid=0x4750 sleeping[0x00007f1bf0dd9000]
>    java.lang.Thread.State: TIMED_WAITING (sleeping)
>         at java.lang.Thread.sleep(Native Method)
>         at org.apache.geode.management.internal.cli.commands.CreateAlterDestroyRegionCommands.verifyDistributedRegionMbean(CreateAlterDestroyRegionCommands.java:410)
>         at org.apache.geode.management.internal.cli.commands.CreateAlterDestroyRegionCommands.createRegion(CreateAlterDestroyRegionCommands.java:371)
>         at org.apache.geode.redis.internal.RegionProvider.createRegionGlobally(RegionProvider.java:405)
>         at org.apache.geode.redis.internal.RegionProvider.getOrCreateRegion0(RegionProvider.java:292)
>         at org.apache.geode.redis.internal.RegionProvider.getOrCreateRegion(RegionProvider.java:212)
>         at org.apache.geode.redis.internal.executor.hash.HashExecutor.getOrCreateRegion(HashExecutor.java:31)
>         at org.apache.geode.redis.internal.executor.hash.HSetExecutor.executeCommand(HSetExecutor.java:48)
>         at org.apache.geode.redis.internal.ExecutionHandlerContext.executeWithoutTransaction(ExecutionHandlerContext.java:235)
>         at org.apache.geode.redis.internal.ExecutionHandlerContext.executeCommand(ExecutionHandlerContext.java:199)
>         at org.apache.geode.redis.internal.ExecutionHandlerContext.channelRead(ExecutionHandlerContext.java:139)
>         at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:368)
>         at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:353)
>         at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173)
>         at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:368)
>         at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:353)
>         at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:780)
>         at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:100)
>         at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:497)
>         at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:465)
>         at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:359)
>         at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101)
>         at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)