You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/24 21:25:00 UTC
[jira] [Commented] (BEAM-2675) Consolidate ValidatesRunner Groovy
Definitions
[ https://issues.apache.org/jira/browse/BEAM-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099142#comment-16099142 ]
ASF GitHub Bot commented on BEAM-2675:
--------------------------------------
GitHub user jasonkuster opened a pull request:
https://github.com/apache/beam/pull/3631
[BEAM-2675] Consolidate ValidatesRunner suite building into one file.
Signed-off-by: Jason Kuster <ja...@google.com>
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This change reduces duplication in the ValidatesRunner tests and avoids the proliferation of additional files in favor of the minimum information necessary (runner name, maven args to run) for the test.
R: @kennknowles
Feel free to punt to someone else -- assigning to you as you've been working with the ValidatesRunner tests for a while.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasonkuster/beam vr-consolidate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3631.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3631
----
commit f48be1487cb69294460541a09cea4a27819f32fe
Author: Jason Kuster <ja...@google.com>
Date: 2017-07-24T21:12:18Z
Consolidate ValidatesRunner suite building into one file.
Signed-off-by: Jason Kuster <ja...@google.com>
----
> Consolidate ValidatesRunner Groovy Definitions
> ----------------------------------------------
>
> Key: BEAM-2675
> URL: https://issues.apache.org/jira/browse/BEAM-2675
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Jason Kuster
> Assignee: Jason Kuster
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)