You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/10 01:52:24 UTC
[GitHub] codecov-io commented on issue #3671: Make different PinotFS
concrete classes have the same behaviors
codecov-io commented on issue #3671: Make different PinotFS concrete classes have the same behaviors
URL: https://github.com/apache/incubator-pinot/pull/3671#issuecomment-452940403
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=h1) Report
> Merging [#3671](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/493ed643e1e5a852cf2549cfe76ef4b3f1e7e0d4?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3671 +/- ##
============================================
+ Coverage 70.89% 70.96% +0.07%
- Complexity 4 44 +40
============================================
Files 1014 1014
Lines 46519 46561 +42
Branches 6214 6225 +11
============================================
+ Hits 32980 33043 +63
+ Misses 11367 11345 -22
- Partials 2172 2173 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/java/com/linkedin/pinot/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9maWxlc3lzdGVtL1Bpbm90RlMuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvU2VnbWVudERlbGV0aW9uTWFuYWdlci5qYXZh) | `79.33% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/com/linkedin/pinot/filesystem/LocalPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9maWxlc3lzdGVtL0xvY2FsUGlub3RGUy5qYXZh) | `87.5% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/com/linkedin/pinot/filesystem/HadoopPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtaGFkb29wLWZpbGVzeXN0ZW0vc3JjL21haW4vamF2YS9jb20vbGlua2VkaW4vcGlub3QvZmlsZXN5c3RlbS9IYWRvb3BQaW5vdEZTLmphdmE=) | `70.21% <83.6%> (+70.21%)` | `40 <28> (+40)` | :arrow_up: |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vT2ZmbGluZVNlZ21lbnRJbnRlcnZhbENoZWNrZXIuamF2YQ==) | `30.76% <0%> (-43.96%)` | `0% <0%> (ø)` | |
| [...nkedin/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL1ZhbGlkYXRpb25NZXRyaWNzLmphdmE=) | `43.47% <0%> (-36.24%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `62.22% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [...ore/query/scheduler/resources/ResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3NjaGVkdWxlci9yZXNvdXJjZXMvUmVzb3VyY2VNYW5hZ2VyLmphdmE=) | `87.09% <0%> (-9.68%)` | `0% <0%> (ø)` | |
| [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2suamF2YQ==) | `69.09% <0%> (-9.1%)` | `0% <0%> (ø)` | |
| [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `65.45% <0%> (-7.28%)` | `0% <0%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=footer). Last update [493ed64...76f8e20](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org