[GitHub] [drill] luocooong commented on a change in pull request #2483: DRILL-8149: large xlsx configs

[GitBox <gi...@apache.org>]

luocooong commented on a change in pull request #2483:
URL: https://github.com/apache/drill/pull/2483#discussion_r820607069



##########
File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -230,6 +239,18 @@ private void openFile(FileScanFramework.FileSchemaNegotiator negotiator) {
     try {
       fsStream = negotiator.fileSystem().openPossiblyCompressedStream(split.getPath());
 
+      if (readerConfig.maxArraySize >= 0) {

Review comment:
       Is it possible to add the unit tests for these three options? we can refer to the : `TestExcelFormat#testLastRowQuery()`.

##########
File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java
##########
@@ -98,6 +109,34 @@ public String getSheetName() {
     return sheetName;
   }
 
+  /**
+   * See the <code>setByteArrayMaxOverride</code> section in the Apache POI

Review comment:
       Is it possible to update the `drill/contrib/format-excel/README.md` file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org