You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/20 12:27:58 UTC

[jira] [Commented] (ARIES-1641) OsgiServiceProvider annotation does not publish service.ranking property as integer

    [ https://issues.apache.org/jira/browse/ARIES-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764093#comment-15764093 ] 

ASF GitHub Bot commented on ARIES-1641:
---------------------------------------

GitHub user michaldabrowski opened a pull request:

    https://github.com/apache/aries/pull/60

    [ARIES-1641] Read "service.ranking" property as ranking attribute in service element

    https://issues.apache.org/jira/browse/ARIES-1641

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaldabrowski/aries ARIES-1641

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit ae92f181eeb66ac5eb2db4f395f5ea3ecd27331b
Author: Michał Dąbrowski <mi...@dabrowski.io>
Date:   2016-12-20T12:15:05Z

    [ARIES-1641] Read "service.ranking" property as ranking attribute in service element

----


> OsgiServiceProvider annotation does not publish service.ranking property as integer
> -----------------------------------------------------------------------------------
>
>                 Key: ARIES-1641
>                 URL: https://issues.apache.org/jira/browse/ARIES-1641
>             Project: Aries
>          Issue Type: Bug
>          Components: Blueprint
>            Reporter: Dominik Przybysz
>            Assignee: Dominik Przybysz
>            Priority: Critical
>             Fix For: blueprint-maven-plugin-1.6.0
>
>
> There is no such option to generate service.ranking property using @OsgiServiceProvider annotation. 
> {code:groovy}
> @OsgiServiceProvider(classes = [TaskRepository])
> @Properties([
>         @Property(name = "type", value = "db"),
>         @Property(name = "service.ranking", value = "100"),
> ])
> {code}
> generates blueprint
> {code:xml}
> <service ref="dbRepository" interface="org.github.alien11689.osgi.task.api.TaskRepository">    
>     <service-properties>
>         <entry key="type" value="db"/>
>         <entry key="service.ranking" value="100"/>
>     </service-properties>
> </service>
> {code}
> and service properties in Apache Karaf:
> {code}
>  osgi.service.blueprint.compname = dbRepository
>  service.bundleid = 54
>  service.id = 274
>  service.scope = bundle
>  type = db
> {code}
> The best option is to convert service.ranking property from @Property annotation as ranking attribute in service element.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)