[GitHub] incubator-weex pull request #1248: [WEEX-441][core] mv core logic from core_...

[lucky-chen <gi...@git.apache.org>]

GitHub user lucky-chen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1248

    [WEEX-441][core] mv core logic from core_android_impl to bridge.cpp

    core logic should not be impl in android code
    
    - mv setXXX to bridge.cpp
    - weexcore_impl_android call interface of bridge

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucky-chen/incubator-weex core-feature-core_api_bridge

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1248
    
----
commit 152770a4ce74479f7e243b3dd54bfe36fc4453d2
Author: zhongcang <qh...@...>
Date:   2018-06-07T08:32:18Z

    [WEEX-441][core] mv core logic from core_android_impl to bridge.cpp

----


---

[GitHub] incubator-weex issue #1248: [WEEX-441][core] mv core logic from core_android...

[weex-bot <gi...@git.apache.org>]

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1248
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---