You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/27 03:59:05 UTC
[GitHub] [incubator-kyuubi] gabrywu opened a new pull request, #2487: fix test command to make it runnable
gabrywu opened a new pull request, #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487
### _Why are the changes needed?_
only change testing.md
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2487: fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487#discussion_r859359830
##########
docs/develop_tools/testing.md:
##########
@@ -37,7 +37,7 @@ The following is an example of a command to run all the tests:
## Running Tests for a Module
```bash
-./build/mvn clean test -pl :kyuubi-common
+./build/mvn clean test -pl kyuubi-common
Review Comment:
And the previous Running Tests Fully should be `./build/mvn clean install`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2487: fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487#discussion_r859474349
##########
docs/develop_tools/testing.md:
##########
@@ -37,7 +37,7 @@ The following is an example of a command to run all the tests:
## Running Tests for a Module
```bash
-./build/mvn clean test -pl :kyuubi-common
+./build/mvn clean test -pl kyuubi-common
Review Comment:
yea, `kyuubi-common` works because it does not depends on `hive-jdbc-shaded`, if you try to test `kyuubi-spark-sql-engine`, the `mvn clean test` would not not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2487: fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487#discussion_r859359420
##########
docs/develop_tools/testing.md:
##########
@@ -37,7 +37,7 @@ The following is an example of a command to run all the tests:
## Running Tests for a Module
```bash
-./build/mvn clean test -pl :kyuubi-common
+./build/mvn clean test -pl kyuubi-common
Review Comment:
`./build/mvn clean install -pl kyuubi-common`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2487: fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487#issuecomment-1110562693
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2487](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c6d1df) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/3ecdd42286d2b47b3c2b7b090f4041e8c52e5e99?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ecdd42) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2487 +/- ##
============================================
+ Coverage 63.18% 63.76% +0.58%
Complexity 69 69
============================================
Files 366 371 +5
Lines 17442 17612 +170
Branches 2342 2348 +6
============================================
+ Hits 11020 11231 +211
+ Misses 5396 5342 -54
- Partials 1026 1039 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/engine/hive/HiveProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvaGl2ZS9IaXZlUHJvY2Vzc0J1aWxkZXIuc2NhbGE=) | `84.31% <0.00%> (-0.80%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `76.38% <0.00%> (-0.33%)` | :arrow_down: |
| [.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlDb25uZWN0aW9uLmphdmE=) | `4.35% <0.00%> (-0.03%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `68.00% <0.00%> (ø)` | |
| [...org/apache/kyuubi/credentials/CredentialsRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9DcmVkZW50aWFsc1JlZi5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
| [...apache/kyuubi/engine/JpsApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvSnBzQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `83.87% <0.00%> (ø)` | |
| [.../main/scala/org/apache/kyuubi/engine/package.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvcGFja2FnZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/kyuubi/engine/ApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `100.00% <0.00%> (ø)` | |
| [...pache/kyuubi/engine/YarnApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvWWFybkFwcGxpY2F0aW9uT3BlcmF0aW9uLnNjYWxh) | `78.04% <0.00%> (ø)` | |
| [...pache/kyuubi/engine/KyuubiApplicationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvS3l1dWJpQXBwbGljYXRpb25NYW5hZ2VyLnNjYWxh) | `65.90% <0.00%> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3ecdd42...7c6d1df](https://codecov.io/gh/apache/incubator-kyuubi/pull/2487?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2487: Fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487#issuecomment-1111017421
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2487: fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487#discussion_r859732126
##########
docs/develop_tools/testing.md:
##########
@@ -37,7 +37,7 @@ The following is an example of a command to run all the tests:
## Running Tests for a Module
```bash
-./build/mvn clean test -pl :kyuubi-common
+./build/mvn clean test -pl kyuubi-common
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2487: fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2487:
URL: https://github.com/apache/incubator-kyuubi/pull/2487#discussion_r859377001
##########
docs/develop_tools/testing.md:
##########
@@ -37,7 +37,7 @@ The following is an example of a command to run all the tests:
## Running Tests for a Module
```bash
-./build/mvn clean test -pl :kyuubi-common
+./build/mvn clean test -pl kyuubi-common
Review Comment:
`./build/mvn clean test -pl kyuubi-common` works well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #2487: Fix test command to make it runnable
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #2487: Fix test command to make it runnable
URL: https://github.com/apache/incubator-kyuubi/pull/2487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org