You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/09/04 11:40:44 UTC
[commons-codec] 01/04: Improve variable name to describe the bug in
Codec 101.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git
commit 738b50de4d72083a93b8ff57c83b112f5ecd882f
Author: aherbert <ah...@apache.org>
AuthorDate: Fri Sep 4 12:14:50 2020 +0100
Improve variable name to describe the bug in Codec 101.
---
.../java/org/apache/commons/codec/binary/Base64InputStreamTest.java | 4 ++--
src/test/java/org/apache/commons/codec/binary/Base64TestData.java | 6 +++++-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/test/java/org/apache/commons/codec/binary/Base64InputStreamTest.java b/src/test/java/org/apache/commons/codec/binary/Base64InputStreamTest.java
index 1e80dde..c65d155 100644
--- a/src/test/java/org/apache/commons/codec/binary/Base64InputStreamTest.java
+++ b/src/test/java/org/apache/commons/codec/binary/Base64InputStreamTest.java
@@ -91,7 +91,7 @@ public class Base64InputStreamTest {
*/
@Test
public void testCodec101() throws Exception {
- final byte[] codec101 = StringUtils.getBytesUtf8(Base64TestData.CODEC_101_MULTIPLE_OF_3);
+ final byte[] codec101 = StringUtils.getBytesUtf8(Base64TestData.CODEC_101_INPUT_LENGTH_IS_MULTIPLE_OF_3);
final ByteArrayInputStream bais = new ByteArrayInputStream(codec101);
try (final Base64InputStream in = new Base64InputStream(bais)) {
final byte[] result = new byte[8192];
@@ -120,7 +120,7 @@ public class Base64InputStreamTest {
*/
@Test
public void testInputStreamReader() throws Exception {
- final byte[] codec101 = StringUtils.getBytesUtf8(Base64TestData.CODEC_101_MULTIPLE_OF_3);
+ final byte[] codec101 = StringUtils.getBytesUtf8(Base64TestData.CODEC_101_INPUT_LENGTH_IS_MULTIPLE_OF_3);
final ByteArrayInputStream bais = new ByteArrayInputStream(codec101);
final Base64InputStream in = new Base64InputStream(bais);
final InputStreamReader isr = new InputStreamReader(in);
diff --git a/src/test/java/org/apache/commons/codec/binary/Base64TestData.java b/src/test/java/org/apache/commons/codec/binary/Base64TestData.java
index 5e45860..d99f3c2 100644
--- a/src/test/java/org/apache/commons/codec/binary/Base64TestData.java
+++ b/src/test/java/org/apache/commons/codec/binary/Base64TestData.java
@@ -28,7 +28,11 @@ import java.util.Random;
*/
public class Base64TestData {
- public static final String CODEC_101_MULTIPLE_OF_3 = "124";
+ /**
+ * A valid base 64 encoding that has a length that is a multiple of 3.
+ * @see <a href="https://issues.apache.org/jira/browse/CODEC-101">Codec 101</a>
+ */
+ public static final String CODEC_101_INPUT_LENGTH_IS_MULTIPLE_OF_3 = "124";
public static final String CODEC_98_NPE
= "YWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXpBQkNERUZHSElKS0xNTk9QUVJTVFVWV1hZWjAxMjM";