You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/06/13 19:12:33 UTC

[native-toolchain-CR] IMPALA-14139: Build on Ubuntu 24.04

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23023


Change subject: IMPALA-14139: Build on Ubuntu 24.04
......................................................................

IMPALA-14139: Build on Ubuntu 24.04

Updates binutils to match the version on Ubuntu 24.04.

Updates Kudu to head of branch-1.18.x for build fixes.

Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
---
M buildall.sh
M docker/all/postinstall.sh
A docker/ubuntu2404.df
M init.sh
M source/kudu/build.sh
5 files changed, 53 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/23/23023/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
Gerrit-Change-Number: 23023
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[native-toolchain-CR] IMPALA-14139: Build on Ubuntu 24.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23023 )

Change subject: IMPALA-14139: Build on Ubuntu 24.04
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23023/1/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/23023/1/buildall.sh@210
PS1, Line 210:   # branch-1.18.x on June 13, 2025
We need a newer version for https://github.com/apache/kudu/commit/38ec08c3c0. However before that Kudu moved to a newer version of Gradle and broke publishing, which breaks our current method of adding the Java dependencies, so we also need https://gerrit.cloudera.org/c/22768/.



-- 
To view, visit http://gerrit.cloudera.org:8080/23023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
Gerrit-Change-Number: 23023
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jun 2025 20:46:34 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-14139: Build on Ubuntu 24.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/23023 )

Change subject: IMPALA-14139: Build on Ubuntu 24.04
......................................................................


Abandoned

Use https://gerrit.cloudera.org/c/23134 instead.
-- 
To view, visit http://gerrit.cloudera.org:8080/23023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
Gerrit-Change-Number: 23023
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[native-toolchain-CR] IMPALA-14139: Build on Ubuntu 24.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23023 )

Change subject: IMPALA-14139: Build on Ubuntu 24.04
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23023/1/docker/ubuntu2404.df
File docker/ubuntu2404.df:

http://gerrit.cloudera.org:8080/#/c/23023/1/docker/ubuntu2404.df@1
PS1, Line 1: FROM ubuntu:24.04
I still need to test building with this container.



-- 
To view, visit http://gerrit.cloudera.org:8080/23023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
Gerrit-Change-Number: 23023
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jun 2025 20:46:50 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-14139: Build on Ubuntu 24.04

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Laszlo Gaal, Joe McDonnell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23023

to look at the new patch set (#2).

Change subject: IMPALA-14139: Build on Ubuntu 24.04
......................................................................

IMPALA-14139: Build on Ubuntu 24.04

Updates binutils to match the version on Ubuntu 24.04.

Updates Kudu to head of branch-1.18.x for build fixes. Still needs
https://gerrit.cloudera.org/c/22768/.

Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
---
M buildall.sh
M docker/all/postinstall.sh
A docker/ubuntu2404.df
M init.sh
M source/kudu/build.sh
5 files changed, 53 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/23/23023/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
Gerrit-Change-Number: 23023
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[native-toolchain-CR] IMPALA-14139: Build on Ubuntu 24.04

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23023 )

Change subject: IMPALA-14139: Build on Ubuntu 24.04
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23023/1/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/23023/1/buildall.sh@210
PS1, Line 210:   # branch-1.18.x on June 13, 2025
> We need a newer version for https://github.com/apache/kudu/commit/38ec08c3c
Just FYI: https://gerrit.cloudera.org/#/c/22768/ is in the upstream Kudu git repo as of 2025-06-23 19:00 PDT.



-- 
To view, visit http://gerrit.cloudera.org:8080/23023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35782921381dcc60de0a3f80c9e65a68c5b2055d
Gerrit-Change-Number: 23023
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 03:38:21 +0000
Gerrit-HasComments: Yes