You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/15 11:22:55 UTC
[GitHub] [incubator-kyuubi] SteNicholas opened a new pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
SteNicholas opened a new pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Set Spark 3.2.1 as default.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040459614
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1913](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebd175d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d90c6648d73f4750382108c89858c4fec3e1b5fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d90c664) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ebd175d differs from pull request most recent head 2167223. Consider uploading reports for the commit 2167223 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1913 +/- ##
============================================
+ Coverage 60.72% 60.75% +0.02%
Complexity 72 72
============================================
Files 298 301 +3
Lines 14687 14714 +27
Branches 1890 1894 +4
============================================
+ Hits 8919 8939 +20
- Misses 5014 5016 +2
- Partials 754 759 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `94.87% <0.00%> (-2.50%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.88% <0.00%> (-2.46%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.27% <0.00%> (-0.13%)` | :arrow_down: |
| [...pache/kyuubi/plugin/DefaultSessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vRGVmYXVsdFNlc3Npb25Db25mQWR2aXNvci5qYXZh) | `100.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/plugin/PluginLoader.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vUGx1Z2luTG9hZGVyLnNjYWxh) | `91.66% <0.00%> (ø)` | |
| [...a/org/apache/kyuubi/plugin/SessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vU2Vzc2lvbkNvbmZBZHZpc29yLmphdmE=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d90c664...2167223](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040459614
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1913](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebd175d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d90c6648d73f4750382108c89858c4fec3e1b5fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d90c664) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ebd175d differs from pull request most recent head 2167223. Consider uploading reports for the commit 2167223 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1913 +/- ##
============================================
+ Coverage 60.72% 60.75% +0.02%
Complexity 72 72
============================================
Files 298 301 +3
Lines 14687 14714 +27
Branches 1890 1894 +4
============================================
+ Hits 8919 8939 +20
- Misses 5014 5016 +2
- Partials 754 759 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `94.87% <0.00%> (-2.50%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.88% <0.00%> (-2.46%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.27% <0.00%> (-0.13%)` | :arrow_down: |
| [...pache/kyuubi/plugin/DefaultSessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vRGVmYXVsdFNlc3Npb25Db25mQWR2aXNvci5qYXZh) | `100.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/plugin/PluginLoader.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vUGx1Z2luTG9hZGVyLnNjYWxh) | `91.66% <0.00%> (ø)` | |
| [...a/org/apache/kyuubi/plugin/SessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vU2Vzc2lvbkNvbmZBZHZpc29yLmphdmE=) | `100.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d90c664...2167223](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040462135
@pan3793, thanks for your review. I have addressed your comments and please help to review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040462135
@pan3793, thanks for your review. I have addressed your comments and please help to review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#discussion_r806731418
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we should also change `delta.version`, because the minor version of delta and spark is one-one mapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#discussion_r806734811
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can leave some comments here, e.g. 'if change the minor version of spark, don't forget to change the deafult `delta.version`'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#discussion_r806730120
##########
File path: docs/integrations/delta_lake_with_azure_blob.md
##########
@@ -106,7 +106,7 @@ Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
- /___/ .__/\_,_/_/ /_/\_\ version 3.1.2
+ /___/ .__/\_,_/_/ /_/\_\ version 3.2.1
Review comment:
please revert this one, it may makes the context inconsistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040520950
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#discussion_r806730120
##########
File path: docs/integrations/delta_lake_with_azure_blob.md
##########
@@ -106,7 +106,7 @@ Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
- /___/ .__/\_,_/_/ /_/\_\ version 3.1.2
+ /___/ .__/\_,_/_/ /_/\_\ version 3.2.1
Review comment:
please revert this one, it may makes the context conflict
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we should also change `delta.version`, because the minor version of delta and spark is one-one mapping
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can left some comments here, e.g. 'if change minor version of spark, don't forget to change the deafult `delta.version`'
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can leave some comments here, e.g. 'if change minor version of spark, don't forget to change the deafult `delta.version`'
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can leave some comments here, e.g. 'if change the minor version of spark, don't forget to change the deafult `delta.version`'
##########
File path: docs/integrations/delta_lake_with_azure_blob.md
##########
@@ -106,7 +106,7 @@ Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
- /___/ .__/\_,_/_/ /_/\_\ version 3.1.2
+ /___/ .__/\_,_/_/ /_/\_\ version 3.2.1
Review comment:
please revert this one, it may makes the context inconsistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#discussion_r806734811
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can left some comments here, e.g. 'if change minor version of spark, don't forget to change the deafult `delta.version`'
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can leave some comments here, e.g. 'if change minor version of spark, don't forget to change the deafult `delta.version`'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040459614
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1913](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebd175d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d90c6648d73f4750382108c89858c4fec3e1b5fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d90c664) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ebd175d differs from pull request most recent head 1a6e4c6. Consider uploading reports for the commit 1a6e4c6 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1913 +/- ##
============================================
+ Coverage 60.72% 60.75% +0.02%
Complexity 72 72
============================================
Files 298 301 +3
Lines 14687 14714 +27
Branches 1890 1894 +4
============================================
+ Hits 8919 8939 +20
- Misses 5014 5016 +2
- Partials 754 759 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `94.87% <0.00%> (-2.50%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.88% <0.00%> (-2.46%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.27% <0.00%> (-0.13%)` | :arrow_down: |
| [...a/org/apache/kyuubi/plugin/SessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vU2Vzc2lvbkNvbmZBZHZpc29yLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...pache/kyuubi/plugin/DefaultSessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vRGVmYXVsdFNlc3Npb25Db25mQWR2aXNvci5qYXZh) | `100.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/plugin/PluginLoader.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vUGx1Z2luTG9hZGVyLnNjYWxh) | `91.66% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d90c664...1a6e4c6](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#discussion_r806730120
##########
File path: docs/integrations/delta_lake_with_azure_blob.md
##########
@@ -106,7 +106,7 @@ Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
- /___/ .__/\_,_/_/ /_/\_\ version 3.1.2
+ /___/ .__/\_,_/_/ /_/\_\ version 3.2.1
Review comment:
please revert this one, it may makes the context conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040459614
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1913](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebd175d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d90c6648d73f4750382108c89858c4fec3e1b5fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d90c664) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ebd175d differs from pull request most recent head 1a6e4c6. Consider uploading reports for the commit 1a6e4c6 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1913 +/- ##
============================================
+ Coverage 60.72% 60.75% +0.02%
Complexity 72 72
============================================
Files 298 301 +3
Lines 14687 14714 +27
Branches 1890 1894 +4
============================================
+ Hits 8919 8939 +20
- Misses 5014 5016 +2
- Partials 754 759 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `94.87% <0.00%> (-2.50%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.88% <0.00%> (-2.46%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.27% <0.00%> (-0.13%)` | :arrow_down: |
| [...a/org/apache/kyuubi/plugin/SessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vU2Vzc2lvbkNvbmZBZHZpc29yLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...pache/kyuubi/plugin/DefaultSessionConfAdvisor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vRGVmYXVsdFNlc3Npb25Db25mQWR2aXNvci5qYXZh) | `100.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/plugin/PluginLoader.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wbHVnaW4vUGx1Z2luTG9hZGVyLnNjYWxh) | `91.66% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d90c664...1a6e4c6](https://codecov.io/gh/apache/incubator-kyuubi/pull/1913?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#issuecomment-1040520950
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1913: [KYUUBI #1876] Set Spark 3.2.1 as default
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org