[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1796: fs: Call RELEASE_SEARCH to free resource in pseudorename

[GitBox <gi...@apache.org>]

btashton commented on a change in pull request #1796:
URL: https://github.com/apache/incubator-nuttx/pull/1796#discussion_r489187518



##########
File path: fs/vfs/fs_stat.c
##########
@@ -58,7 +58,8 @@
  ****************************************************************************/
 
 static inline int statroot(FAR struct stat *buf);
-int stat_recursive(FAR const char *path, FAR struct stat *buf, int resolve);
+static int
+stat_recursive(FAR const char *path, FAR struct stat *buf, int resolve);

Review comment:
       while nxstyle will pass on this I believe the preferred way to handle this is to keep the type on the same line as the function name and then drop the last argument onto the next line aligned with the first argument.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org