[jira] Closed: (OFBIZ-618) Customer must add a virtual product to the cart to get the price of that product.

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-618.
---------------------------------

    Resolution: Fixed

Thanks Eric,

I reviewed your patch, here are my remarks :

Please don't use tabs but spaces for indentation (4 in any other than FTL files, 2 in FTL files). Take care with your indentations. Be sure to read this document before submitting a patch : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

I agree that you patch fix the issue with IE 6/7 but there was a problem of localisation in it. 
You use 
                     numberFormat = NumberFormat.getCurrencyInstance();
but in FTL files we use the macro <@ofbizCurrency wich takes care of store parameters. For instance on my machine, with OFBiz OOTB, the variant price is given in EUROS (I lve in France) and should be in Dollar because it's how it's set in product store. I changed the line above to be

                    String localeString = productStore.getString("defaultLocaleString");
                    if (UtilValidate.isNotEmpty(localeString)) {
                        locale = UtilMisc.parseLocale(localeString);
                    }                    
                    numberFormat = NumberFormat.getCurrencyInstance(locale);                    

It's not perfect (USD is missing) but it ok. I commited in trunk rev. 584531

> Customer must add a virtual product to the cart to get the price of that product. 
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-618
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-618
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Eric Crawford
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: diff.log, productdetail-bsh.patch, productdetail-ftl.patch, productdetail.patch, productdetail.patch
>
>
> When a customer chooses a the required feature(s) for a virtual product, they are forced to add the item to the cart in order to know the price of that item. The product image is updated, but the price is not dynamically updated when the features are selected. The product description also remains that of the virtual product and is not updated with the variant's product information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.