You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/07 06:28:40 UTC

[GitHub] [hudi] rmpifer commented on a change in pull request #2413: [HUDI-1513] Introduce WriteClient#preWrite() and relocate metadata table syncing

rmpifer commented on a change in pull request #2413:
URL: https://github.com/apache/hudi/pull/2413#discussion_r553132216



##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/compact/TestAsyncCompaction.java
##########
@@ -50,7 +51,9 @@
 public class TestAsyncCompaction extends CompactionTestBase {
 
   private HoodieWriteConfig getConfig(Boolean autoCommit) {
-    return getConfigBuilder(autoCommit).build();
+    return getConfigBuilder(autoCommit)
+        .withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(true).validate(true).build())

Review comment:
       Do we want this test suite to run against only metadata enabled table from now on? If we want coverage for both can we parameterize tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org