You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/10/11 03:43:46 UTC
[GitHub] incubator-weex pull request #783: * [ios] bugfix list view can not scroll
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/783
* [ios] bugfix list view can not scroll
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex bugfix-release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #783
----
commit 9833852c0758b37f85a33db7592464d21f8cddce
Author: acton393 <zh...@gmail.com>
Date: 2017-10-11T03:39:53Z
* [ios] bugfix list view can not scroll
----
---
[GitHub] incubator-weex pull request #783: * [ios] bugfix list view can not scroll
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/783#discussion_r143906471
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m ---
@@ -232,13 +243,13 @@ - (void)updateAttributes:(NSDictionary *)attributes
((UIScrollView *)self.view).scrollEnabled = _scrollable;
}
if (attributes[@"alwaysScrollableHorizontal"]) {
- _alwaysScrollableHorizontal = [WXConvert BOOL:attributes[@"alwaysScrollableHorizontal"]];
- ((UIScrollView*)self.view).alwaysBounceHorizontal = _alwaysScrollableHorizontal;
+ _alwaysScrollableHorizontal = [WXConvert NSString:attributes[@"alwaysScrollableHorizontal"]];
--- End diff --
why has twice transform?
---
[GitHub] incubator-weex pull request #783: * [ios] bugfix list view can not scroll
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/783
---
[GitHub] incubator-weex pull request #783: * [ios] bugfix list view can not scroll
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/783#discussion_r143906867
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m ---
@@ -232,13 +243,13 @@ - (void)updateAttributes:(NSDictionary *)attributes
((UIScrollView *)self.view).scrollEnabled = _scrollable;
}
if (attributes[@"alwaysScrollableHorizontal"]) {
- _alwaysScrollableHorizontal = [WXConvert BOOL:attributes[@"alwaysScrollableHorizontal"]];
- ((UIScrollView*)self.view).alwaysBounceHorizontal = _alwaysScrollableHorizontal;
+ _alwaysScrollableHorizontal = [WXConvert NSString:attributes[@"alwaysScrollableHorizontal"]];
--- End diff --
actually I want to save the string value , as bool can not expression third case.
---
[GitHub] incubator-weex issue #783: * [ios] bugfix list view can not scroll
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/783
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---