You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2019/04/07 21:02:12 UTC
[Impala-ASF-CR] spill hwm metric
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12955
Change subject: spill hwm metric
......................................................................
spill hwm metric
Change-Id: I589d5b16f935034b88399b365d94c8316713b990
Delete mistakenly added file.
Change-Id: Iafaadaa8a34e57725eafff124858b9b3991e1ce6
---
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/util/metrics-test.cc
M be/src/util/metrics.h
M common/thrift/metrics.json
5 files changed, 100 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/12955/1
--
To view, visit http://gerrit.cloudera.org:8080/12955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafaadaa8a34e57725eafff124858b9b3991e1ce6
Gerrit-Change-Number: 12955
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] spill hwm metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12955 )
Change subject: spill hwm metric
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2671/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafaadaa8a34e57725eafff124858b9b3991e1ce6
Gerrit-Change-Number: 12955
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 07 Apr 2019 21:47:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] spill hwm metric
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has abandoned this change. ( http://gerrit.cloudera.org:8080/12955 )
Change subject: spill hwm metric
......................................................................
Abandoned
This change wasn't ready for official review. Apologies for the spam.
--
To view, visit http://gerrit.cloudera.org:8080/12955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iafaadaa8a34e57725eafff124858b9b3991e1ce6
Gerrit-Change-Number: 12955
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] spill hwm metric
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12955 )
Change subject: spill hwm metric
......................................................................
Patch Set 1:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc
File be/src/runtime/tmp-file-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@69
PS1, Line 69: const string TMP_FILE_MGR_SCRATCH_SPACE_BYTES_USED_HIGH_WATER_MARK =
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@147
PS1, Line 147: metrics->AddHWMGauge(TMP_FILE_MGR_SCRATCH_SPACE_BYTES_USED_HIGH_WATER_MARK, 0);
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@147
PS1, Line 147: metrics->AddHWMGauge(TMP_FILE_MGR_SCRATCH_SPACE_BYTES_USED_HIGH_WATER_MARK, 0);
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@148
PS1, Line 148:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h
File be/src/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@258
PS1, Line 258: : IntGauge(metric_def, initial_value), hwm_value_(initial_value) {}
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@258
PS1, Line 258: : IntGauge(metric_def, initial_value), hwm_value_(initial_value) {}
tab used for whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@268
PS1, Line 268: /// Atomically sets the current value and atomically sets the high water mark value.
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@272
PS1, Line 272: }
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@293
PS1, Line 293:
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/12955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafaadaa8a34e57725eafff124858b9b3991e1ce6
Gerrit-Change-Number: 12955
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 07 Apr 2019 21:03:00 +0000
Gerrit-HasComments: Yes