You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/25 12:33:47 UTC

[GitHub] [spark] akshatb1 opened a new pull request #29870: Fixing log message for better clarity.

akshatb1 opened a new pull request #29870:
URL: https://github.com/apache/spark/pull/29870


   Fixing log message for better clarity. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] akshatb1 commented on a change in pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
akshatb1 commented on a change in pull request #29870:
URL: https://github.com/apache/spark/pull/29870#discussion_r495842717



##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -568,7 +568,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
     // If spark.executor.heartbeatInterval bigger than spark.network.timeout,
     // it will almost always cause ExecutorLostFailure. See SPARK-22754.
     require(executorTimeoutThresholdMs > executorHeartbeatIntervalMs, "The value of " +
-      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be no less than the value of " +
+      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be greater than the value of " +

Review comment:
       @srowen Thanks for checking it out, yes, that was the intent. Could you please help in closing this PR? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700136644


   **[Test build #129187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129187/testReport)** for PR 29870 at commit [`b113ead`](https://github.com/apache/spark/commit/b113ead148ac798f6652dc0c005d3e3c74e5af2e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700012105


   **[Test build #129187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129187/testReport)** for PR 29870 at commit [`b113ead`](https://github.com/apache/spark/commit/b113ead148ac798f6652dc0c005d3e3c74e5af2e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] akshatb1 commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
akshatb1 commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-699924208


   > Is it possible to make this value property driven?)
   
   These commits are already merged to master (with property driven), not sure why they are showing up in this PR, overall diff is only log fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-698903301


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700138231






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-698903301


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29870:
URL: https://github.com/apache/spark/pull/29870#discussion_r495676471



##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -568,7 +568,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
     // If spark.executor.heartbeatInterval bigger than spark.network.timeout,
     // it will almost always cause ExecutorLostFailure. See SPARK-22754.
     require(executorTimeoutThresholdMs > executorHeartbeatIntervalMs, "The value of " +
-      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be no less than the value of " +
+      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be greater than the value of " +

Review comment:
       Okay. it's probably because English isn't my first language. cc @srowen.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] akshatb1 commented on a change in pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
akshatb1 commented on a change in pull request #29870:
URL: https://github.com/apache/spark/pull/29870#discussion_r495586849



##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -568,7 +568,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
     // If spark.executor.heartbeatInterval bigger than spark.network.timeout,
     // it will almost always cause ExecutorLostFailure. See SPARK-22754.
     require(executorTimeoutThresholdMs > executorHeartbeatIntervalMs, "The value of " +
-      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be no less than the value of " +
+      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be greater than the value of " +

Review comment:
       "no less" than is slightly confusing as the application fails if both values are same, hence changing it to greater. Please let me know if it makes sense. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700053127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] akshatb1 commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
akshatb1 commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700755957


   Thanks, @srowen for the help in merging this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700010209


   @akshatb1 weird, probably because you made a merge commit. I usually just rebase onto master and force-push if necessary, but you needn't usually rebase.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on a change in pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #29870:
URL: https://github.com/apache/spark/pull/29870#discussion_r495715802



##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -568,7 +568,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
     // If spark.executor.heartbeatInterval bigger than spark.network.timeout,
     // it will almost always cause ExecutorLostFailure. See SPARK-22754.
     require(executorTimeoutThresholdMs > executorHeartbeatIntervalMs, "The value of " +
-      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be no less than the value of " +
+      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be greater than the value of " +

Review comment:
       "no less" would be "greater than or equal to" and the check does look for "greater than" so the correction is OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700052922


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33803/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700038024


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33803/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-698903817


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700010336


   Jenkins test this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #29870:
URL: https://github.com/apache/spark/pull/29870


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-698903817


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-698903301


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-698903301






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #29870: Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29870:
URL: https://github.com/apache/spark/pull/29870#discussion_r495547166



##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -568,7 +568,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
     // If spark.executor.heartbeatInterval bigger than spark.network.timeout,
     // it will almost always cause ExecutorLostFailure. See SPARK-22754.
     require(executorTimeoutThresholdMs > executorHeartbeatIntervalMs, "The value of " +
-      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be no less than the value of " +
+      s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be greater than the value of " +

Review comment:
       Isn't it virtually same?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700138231






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700710077


   Merged to master/3.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700012105


   **[Test build #129187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129187/testReport)** for PR 29870 at commit [`b113ead`](https://github.com/apache/spark/commit/b113ead148ac798f6652dc0c005d3e3c74e5af2e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29870: [MINOR][DOCS] Fixing log message for better clarity.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29870:
URL: https://github.com/apache/spark/pull/29870#issuecomment-700053127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org