You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by yongqing <59...@qq.com> on 2020/11/16 06:23:07 UTC

回复: [Improvement][server] When the tenant does not exist, the task execution should throw an exception

+1




------------------&nbsp;原始邮件&nbsp;------------------
发件人:                                                                                                                        "dev"                                                                                    <gaojun2048@apache.org&gt;;
发送时间:&nbsp;2020年11月16日(星期一) 下午2:21
收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;

主题:&nbsp;Re: [Improvement][server] When the tenant does not exist, the task execution should throw an exception



+1

boyi <zhangboyi_mx@163.com&gt; 于2020年11月16日周一 上午10:24写道:

&gt; +1
&gt;
&gt;
&gt; --------------------------------------
&gt; BoYi ZhangE-mail : zhangboyi_mx@163.com
&gt; On 11/16/2020 10:09,CalvinKirs<acm_master@163.com&gt; wrote:
&gt; +1
&gt;
&gt;
&gt; agree with&nbsp; gabrywu
&gt;
&gt;
&gt; Best&nbsp; wishes!
&gt; CalvinKirs
&gt;
&gt;
&gt; On 11/16/2020 09:22,wu shaoj<shaojwu@gmail.com&gt; wrote:
&gt; Can’t agree with you more, I think create a new tenant is in the scope of
&gt; operation engineers.
&gt; We should not exceed one's duties and meddle in others' affairs
&gt;
&gt;
&gt; From: zhuangchong <zhuangchong6@163.com&gt;
&gt; Date: Sunday, November 15, 2020 at 19:29
&gt; To: dev@dolphinscheduler.apache.org <dev@dolphinscheduler.apache.org&gt;
&gt; Subject: [Improvement][server] When the tenant does not exist, the task
&gt; execution should throw an exception
&gt; Hi:
&gt;
&gt; https://github.com/apache/incubator-dolphinscheduler/issues/4069
&gt;
&gt; Describe the question
&gt; During the execution of the workflow task node, if the tenant does not
&gt; exist, the worker will create a new tenant. I think an exception should be
&gt; thrown at this time. Dolphin has a large tenant installation authority,
&gt; which is risky.
&gt;
&gt; What are the current deficiencies and the benefits of improvement
&gt; When the workflow task node is executing, if the tenant does not exist,
&gt; the worker execution throws an exception.
&gt;
&gt; Which version of DolphinScheduler:
&gt; -[dev]
&gt;
&gt; 描述问题
&gt; 工作流任务节点在执行时,如果租户不存在,worker会创建新的租户,我认为此时应该抛出异常,dolphin的安装租户权限大,有操作风险
&gt;
&gt; 目前的不足之处和改进的好处
&gt; 工作流任务节点在执行时,如果租户不存在,worker执行抛出异常。
&gt;
&gt; 哪个版本的DolphinScheduler:
&gt; -[dev]
&gt;


-- 

DolphinScheduler(Incubator)&nbsp; PPMC
Jun Gao 高俊
gaojun2048@gmail.com

Re: [Improvement][server] When the tenant does not exist, the task execution should throw an exception

Posted by leon bao <le...@apache.org>.
+1

Creating tenant account  is not the responsibility of application system.

yongqing <59...@qq.com> 于2020年11月16日周一 下午2:23写道:

> +1
>
>
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:
>                                                   "dev"
>                                                                 <
> gaojun2048@apache.org&gt;;
> 发送时间:&nbsp;2020年11月16日(星期一) 下午2:21
> 收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;
>
> 主题:&nbsp;Re: [Improvement][server] When the tenant does not exist, the
> task execution should throw an exception
>
>
>
> +1
>
> boyi <zhangboyi_mx@163.com&gt; 于2020年11月16日周一 上午10:24写道:
>
> &gt; +1
> &gt;
> &gt;
> &gt; --------------------------------------
> &gt; BoYi ZhangE-mail : zhangboyi_mx@163.com
> &gt; On 11/16/2020 10:09,CalvinKirs<acm_master@163.com&gt; wrote:
> &gt; +1
> &gt;
> &gt;
> &gt; agree with&nbsp; gabrywu
> &gt;
> &gt;
> &gt; Best&nbsp; wishes!
> &gt; CalvinKirs
> &gt;
> &gt;
> &gt; On 11/16/2020 09:22,wu shaoj<shaojwu@gmail.com&gt; wrote:
> &gt; Can’t agree with you more, I think create a new tenant is in the
> scope of
> &gt; operation engineers.
> &gt; We should not exceed one's duties and meddle in others' affairs
> &gt;
> &gt;
> &gt; From: zhuangchong <zhuangchong6@163.com&gt;
> &gt; Date: Sunday, November 15, 2020 at 19:29
> &gt; To: dev@dolphinscheduler.apache.org <dev@dolphinscheduler.apache.org
> &gt;
> &gt; Subject: [Improvement][server] When the tenant does not exist, the
> task
> &gt; execution should throw an exception
> &gt; Hi:
> &gt;
> &gt; https://github.com/apache/incubator-dolphinscheduler/issues/4069
> &gt <https://github.com/apache/incubator-dolphinscheduler/issues/4069&gt>;
> &gt; Describe the question
> &gt; During the execution of the workflow task node, if the tenant does not
> &gt; exist, the worker will create a new tenant. I think an exception
> should be
> &gt; thrown at this time. Dolphin has a large tenant installation
> authority,
> &gt; which is risky.
> &gt;
> &gt; What are the current deficiencies and the benefits of improvement
> &gt; When the workflow task node is executing, if the tenant does not
> exist,
> &gt; the worker execution throws an exception.
> &gt;
> &gt; Which version of DolphinScheduler:
> &gt; -[dev]
> &gt;
> &gt; 描述问题
> &gt; 工作流任务节点在执行时,如果租户不存在,worker会创建新的租户,我认为此时应该抛出异常,dolphin的安装租户权限大,有操作风险
> &gt;
> &gt; 目前的不足之处和改进的好处
> &gt; 工作流任务节点在执行时,如果租户不存在,worker执行抛出异常。
> &gt;
> &gt; 哪个版本的DolphinScheduler:
> &gt; -[dev]
> &gt;
>
>
> --
>
> DolphinScheduler(Incubator)&nbsp; PPMC
> Jun Gao 高俊
> gaojun2048@gmail.com



-- 
DolphinScheduler(Incubator)  PPMC
BaoLiang 鲍亮
leonbao@apache.org