You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jo...@apache.org on 2017/09/03 12:51:28 UTC
[06/42] mesos git commit: CMake: Removed `GroupSource` usage from
`libprocess`.
CMake: Removed `GroupSource` usage from `libprocess`.
Source grouping is a cosmetic change that only has an effect if
you load this project into an IDE (such as XCode or Visual Studio).
The existing source grouping is brittle and is not vital for the
CMake build system MVP, so we are removing it to reduce code churn.
Review: https://reviews.apache.org/r/61350/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/96866d2c
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/96866d2c
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/96866d2c
Branch: refs/heads/master
Commit: 96866d2c6105cda479a33371401377a77281a0e9
Parents: ae778e4
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Authored: Sat Sep 2 09:07:34 2017 -0700
Committer: Joseph Wu <jo...@apache.org>
Committed: Sun Sep 3 05:51:05 2017 -0700
----------------------------------------------------------------------
3rdparty/libprocess/cmake/ProcessConfigure.cmake | 17 -----------------
3rdparty/libprocess/src/CMakeLists.txt | 9 ---------
3rdparty/libprocess/src/tests/CMakeLists.txt | 9 ---------
3 files changed, 35 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/96866d2c/3rdparty/libprocess/cmake/ProcessConfigure.cmake
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/cmake/ProcessConfigure.cmake b/3rdparty/libprocess/cmake/ProcessConfigure.cmake
index b9281b1..e246eaa 100755
--- a/3rdparty/libprocess/cmake/ProcessConfigure.cmake
+++ b/3rdparty/libprocess/cmake/ProcessConfigure.cmake
@@ -48,23 +48,6 @@ set(PROCESS_PACKAGE_VERSION 0.0.1)
set(PROCESS_PACKAGE_SOVERSION 0)
set(PROCESS_TARGET process-${PROCESS_PACKAGE_VERSION})
-# SOURCE GROUPS. Allows IDEs to group header files for projects taking a
-# dependency on this package.
-########################################################################
-file(
- GLOB_RECURSE
- PROCESS_HEADERS
- "${PROCESS_INCLUDE_DIR}/process/*.hpp"
- )
-
-macro(GROUP_PROCESS_HEADERS)
- GROUP_SOURCE(
- "Libprocess Public Headers"
- "${PROCESS_INCLUDE_DIR}/process"
- "${PROCESS_INCLUDE_DIR}/process"
- "*.h*")
-endmacro()
-
# DEFINE PROCESS LIBRARY DEPENDENCIES. Tells the process library build targets
# download/configure/build all third-party libraries before attempting to build.
################################################################################
http://git-wip-us.apache.org/repos/asf/mesos/blob/96866d2c/3rdparty/libprocess/src/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/CMakeLists.txt b/3rdparty/libprocess/src/CMakeLists.txt
index fbad7a0..1ffa2c9 100644
--- a/3rdparty/libprocess/src/CMakeLists.txt
+++ b/3rdparty/libprocess/src/CMakeLists.txt
@@ -121,15 +121,6 @@ else ()
)
endif ()
-GROUP_STOUT_HEADERS()
-GROUP_PROCESS_HEADERS()
-
-GROUP_SOURCE(
- "src"
- "${CMAKE_CURRENT_SOURCE_DIR}"
- "${CMAKE_CURRENT_SOURCE_DIR}"
- "*.[ch]*")
-
set_target_properties(
${PROCESS_TARGET} PROPERTIES
VERSION ${PROCESS_PACKAGE_VERSION}
http://git-wip-us.apache.org/repos/asf/mesos/blob/96866d2c/3rdparty/libprocess/src/tests/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/tests/CMakeLists.txt b/3rdparty/libprocess/src/tests/CMakeLists.txt
index 27451c2..dd46bd2 100644
--- a/3rdparty/libprocess/src/tests/CMakeLists.txt
+++ b/3rdparty/libprocess/src/tests/CMakeLists.txt
@@ -78,15 +78,6 @@ link_directories(${PROCESS_TEST_LIB_DIRS})
###############################################################################
add_executable(${PROCESS_TESTS_TARGET} EXCLUDE_FROM_ALL ${PROCESS_TESTS_SRC})
-GROUP_STOUT_HEADERS()
-GROUP_PROCESS_HEADERS()
-
-GROUP_SOURCE(
- "tests"
- "${CMAKE_CURRENT_SOURCE_DIR}"
- "${CMAKE_CURRENT_SOURCE_DIR}"
- "*.[ch]*")
-
# ADD LINKER FLAGS (generates, e.g., -lglog on Linux).
######################################################
target_link_libraries(${PROCESS_TESTS_TARGET} ${PROCESS_TEST_LIBS})