You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/28 04:34:33 UTC
[GitHub] [incubator-mxnet] leezu opened a new pull request #18183: Fix Dockerfile.publish.test.centos7
leezu opened a new pull request #18183:
URL: https://github.com/apache/incubator-mxnet/pull/18183
Delete lines missed in prior commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18183: Fix Dockerfile.publish.test.centos7
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18183:
URL: https://github.com/apache/incubator-mxnet/pull/18183#issuecomment-620374988
Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, centos-cpu, unix-gpu, sanity, windows-gpu, centos-gpu, windows-cpu, website, unix-cpu, clang, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on pull request #18183: Fix Dockerfile.publish.test.centos7
Posted by GitBox <gi...@apache.org>.
ChaiBapchya edited a comment on pull request #18183:
URL: https://github.com/apache/incubator-mxnet/pull/18183#issuecomment-620392417
Thanks for adding that test so as to ensure docker-cache issues are caught earlier.
So basically now if someone wants to make any changes to docker-cache it can be verified using miscellaneous pipeline test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #18183: Fix Dockerfile.publish.test.centos7
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #18183:
URL: https://github.com/apache/incubator-mxnet/pull/18183#discussion_r416424409
##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -1764,4 +1764,16 @@ def test_artifact_repository() {
}]
}
+def misc_test_docker_cache_build() {
Review comment:
This is duplicate to the docker cache file. Can you use the same script?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #18183: Fix Dockerfile.publish.test.centos7
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #18183:
URL: https://github.com/apache/incubator-mxnet/pull/18183#discussion_r416424409
##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -1764,4 +1764,16 @@ def test_artifact_repository() {
}]
}
+def misc_test_docker_cache_build() {
Review comment:
This is duplicate to the docker cache file. Can you use the same script?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18183: Fix Dockerfile.publish.test.centos7
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18183:
URL: https://github.com/apache/incubator-mxnet/pull/18183#issuecomment-620392417
Thanks for adding that test so as to ensure docker-cache issues are caught earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18183: Fix Dockerfile.publish.test.centos7
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18183:
URL: https://github.com/apache/incubator-mxnet/pull/18183#issuecomment-620394381
Mainly the tests ensures that all dockerfiles are valid. Not only the ones used in some CI pipeline, but also the ones only used in CD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org