You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/21 08:59:17 UTC
[GitHub] [iotdb] THUMarkLau opened a new pull request #5099: [IOTDB-2581] Fix compaction recover in 0.13.0 is not compatible with 0.12.5
THUMarkLau opened a new pull request #5099:
URL: https://github.com/apache/iotdb/pull/5099
see [IOTDB-2581](https://issues.apache.org/jira/browse/IOTDB-2581)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5099: [IOTDB-2581] Fix compaction recover in 0.13.0 is not compatible with 0.12.5
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5099:
URL: https://github.com/apache/iotdb/pull/5099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #5099: [IOTDB-2581] Fix compaction recover in 0.13.0 is not compatible with 0.12.5
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #5099:
URL: https://github.com/apache/iotdb/pull/5099#discussion_r810942566
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileIdentifier.java
##########
@@ -44,8 +44,8 @@
public static final int LOGICAL_SG_OFFSET_IN_LOG = 0;
public static final int VIRTUAL_SG_OFFSET_IN_LOG = 1;
public static final int TIME_PARTITION_OFFSET_IN_LOG = 2;
- public static final int SEQUENCE_OFFSET_IN_LOG = 3;
- public static final int FILE_NAME_OFFSET_IN_LOG = 4;
+ public static final int SEQUENCE_OFFSET_IN_LOG = 4;
+ public static final int FILE_NAME_OFFSET_IN_LOG = 3;
Review comment:
add a javadoc to warn others not modifying this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5099: [IOTDB-2581] Fix compaction recover in 0.13.0 is not compatible with 0.12.5
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5099:
URL: https://github.com/apache/iotdb/pull/5099#issuecomment-1046680471
[](https://coveralls.io/builds/46732734)
Coverage decreased (-0.02%) to 67.789% when pulling **748ccc3f460222a87493f07b447343ffe30f7215 on THUMarkLau:IOTDB-2581** into **aa9efee3905bc0ba78b6c61b1e9207daf99d0d19 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5099: [IOTDB-2581] Fix compaction recover in 0.13.0 is not compatible with 0.12.5
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5099:
URL: https://github.com/apache/iotdb/pull/5099#issuecomment-1046680471
[](https://coveralls.io/builds/46726091)
Coverage decreased (-0.02%) to 67.788% when pulling **3930885c69a7b4bca75cb2550ea4d0db642b2ca6 on THUMarkLau:IOTDB-2581** into **aa9efee3905bc0ba78b6c61b1e9207daf99d0d19 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5099: [IOTDB-2581] Fix compaction recover in 0.13.0 is not compatible with 0.12.5
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5099:
URL: https://github.com/apache/iotdb/pull/5099#issuecomment-1046680471
[](https://coveralls.io/builds/46730922)
Coverage decreased (-0.03%) to 67.785% when pulling **748ccc3f460222a87493f07b447343ffe30f7215 on THUMarkLau:IOTDB-2581** into **aa9efee3905bc0ba78b6c61b1e9207daf99d0d19 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a change in pull request #5099: [IOTDB-2581] Fix compaction recover in 0.13.0 is not compatible with 0.12.5
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #5099:
URL: https://github.com/apache/iotdb/pull/5099#discussion_r811100525
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileIdentifier.java
##########
@@ -44,8 +44,8 @@
public static final int LOGICAL_SG_OFFSET_IN_LOG = 0;
public static final int VIRTUAL_SG_OFFSET_IN_LOG = 1;
public static final int TIME_PARTITION_OFFSET_IN_LOG = 2;
- public static final int SEQUENCE_OFFSET_IN_LOG = 3;
- public static final int FILE_NAME_OFFSET_IN_LOG = 4;
+ public static final int SEQUENCE_OFFSET_IN_LOG = 4;
+ public static final int FILE_NAME_OFFSET_IN_LOG = 3;
Review comment:
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org