[jira] [Commented] (CALCITE-3091) Expose defaultSchema .json parameter to SchemaFactory

["Stamatis Zampetakis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848303#comment-16848303 ] 

Stamatis Zampetakis commented on CALCITE-3091:
----------------------------------------------

Hi [~igrgurina], 

if I understand right you need a way to mark one schema in the JSON model and be able to find the information when you create a Schema with the SchemaFactory.  Isn't it possible to use operand property for this? Do you really need to have access to default schema JSON property?

> Expose defaultSchema .json parameter to SchemaFactory
> -----------------------------------------------------
>
>                 Key: CALCITE-3091
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3091
>             Project: Calcite
>          Issue Type: Improvement
>          Components: jdbc-adapter
>    Affects Versions: 1.19.0
>            Reporter: Ivan Grgurina
>            Priority: Major
>
> Currently, when you use JDBC adapter and have custom schema factory, you provide .json file with your schema definition and link to your SchemaFactory implementation that is called to create that Schema for the rest of the system. 
> That .json file has in root a 'defaultSchema' parameter that Calcite uses to know what the default schema is. Unfortunately, that parameter is not exposed when implementing SchemaFactory interface, and there are use cases where that would be useful.
> For example, one use case is when having multiple custom schemas, to know which one is the default one while you're creating it inside SchemaFactory implementation.
> My specific use-case is I want to use that .json parameter for "filtering" schemas. The current workaround for that is to have two SchemaFactory implementations that are then later connected in code, but it would be easier if I could just check in SchemaFactory if my schema is the defaultSchema and do the appropriate logic there.
> I'm willing to do the work to make this change if someone can point me in the right direction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)