[jira] [Commented] (KAFKA-5660) Don't throw TopologyBuilderException during runtime

["Matthias J. Sax (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104122#comment-16104122 ] 

Matthias J. Sax commented on KAFKA-5660:
----------------------------------------

{{TopologyBuilderException}} got deprecated via KIP-120 and new {{TopologyException}} was introduces. Thus, we need to double check {{TopologyException}}, too.

> Don't throw TopologyBuilderException during runtime
> ---------------------------------------------------
>
>                 Key: KAFKA-5660
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5660
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.11.0.0
>            Reporter: Matthias J. Sax
>
> {{TopologyBuilderException}} is a pre-runtime exception that should only be thrown {{KafkaStreams#start()}} is called.
> However, we do throw {{TopologyBuilderException}} within
> - `SourceNodeFactory#getTopics`
> - `ProcessorContextImpl#getStateStore`
> (and maybe somewhere else: we should double check if there are other places in the code like those).
> We should replace those exception with either {{StreamsException}} or with a new exception type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)