You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/27 03:41:43 UTC
[GitHub] [shardingsphere] MingxingLAI opened a new pull request #10203: refactor ShardingUnicastRoutingEngine
MingxingLAI opened a new pull request #10203:
URL: https://github.com/apache/shardingsphere/pull/10203
Fixes #10202 .
Changes proposed in this pull request:
- Using stream to reduce forloop
- extracting code block to an independent function to reduce the length of route function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10203: refactor ShardingUnicastRoutingEngine
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10203:
URL: https://github.com/apache/shardingsphere/pull/10203#issuecomment-827300516
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10203](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a9d0bb) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c5f300a8e94e6253c51c2e17b49bbcd4ec70b426?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f300a) will **decrease** coverage by `0.00%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10203 +/- ##
============================================
- Coverage 68.08% 68.07% -0.01%
Complexity 680 680
============================================
Files 1696 1696
Lines 29108 29105 -3
Branches 5216 5214 -2
============================================
- Hits 19817 19814 -3
Misses 7772 7772
Partials 1519 1519
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ine/type/unicast/ShardingUnicastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10203/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL3VuaWNhc3QvU2hhcmRpbmdVbmljYXN0Um91dGluZ0VuZ2luZS5qYXZh) | `94.73% <90.00%> (-0.39%)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5f300a...3a9d0bb](https://codecov.io/gh/apache/shardingsphere/pull/10203?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10203: refactor ShardingUnicastRoutingEngine
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10203:
URL: https://github.com/apache/shardingsphere/pull/10203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org